feat: apply manifest namespace to local .apm skills#755
Open
shreejaykurhade wants to merge 2 commits intomicrosoft:mainfrom
Open
feat: apply manifest namespace to local .apm skills#755shreejaykurhade wants to merge 2 commits intomicrosoft:mainfrom
shreejaykurhade wants to merge 2 commits intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR completes support for namespaced skill deployment by propagating the root
apm.ymlnamespaceinto local.apm/skillsintegration.The namespace behavior for skill deployment was already implemented; this change makes project-local skills follow the same rule as dependency-installed skills, so local sub-skills are deployed with names like
acme.design.lintinginstead of unprefixed names.This PR also adds regression coverage for the local
.apmpath and updates docs to reflect the expected namespaced skill folder behavior.Fixes #739
Type of change
Testing
Issue-scoped tests passed locally:
tests/unit/test_local_content_install.pytests/unit/integration/test_skill_integrator.pytests/integration/test_local_install.py -k "namespace or root_apm_skills_use_project_namespace"Note:
24 failed, 4453 passed, 160 skipped, 9 deselected, 11 warnings