MSIX FindPackageFile*() API

[DrusTheAxe]

Implementation of MSIX FindPackageFile*() API Spec#5885

https://task.ms/59424502

NOTE: SearchStatic/DynamicDependencies options are dropped from spec because Windows doesn't expose this information. Get[Current]PackageInfo*() accepts an input to optionally filter package graph entries but output doesn't indicate if a package was statically or dynamically added to the package graph.

[letao-msft]

The IDL says

        /// @note If SearchInstallPath, SearchMutablePath, SearchMachineExternalPath and SearchUserExternalPath
        ///        are omitted then all locations are searched (i.e. specify all or none yields the same result).

But this path doesn't add all those options if none of them is specified (i.e. when only SearchPackages is specified, but none of SearchPath is specified).

[letao-msft]

path = package.GetInstallPath()

This pseudocode doesn't match the implementation.
package_runtime.cpp line 205 checks if SearchInstallPath is in options before getting install path, but here it's unconditional.

---

Refers to: specs/package/Package.md:150 in 50e998b. [](commit_id = 50e998b, deletion_comment = False)

[letao-msft]

var options = GetPackageFilePathOptions.SearchInstallPath |

The IDL only defines GetFilePathOptions.
GetPackageFilePathOptions is an internal C++ impl type.

Same applies throughout.

---

Refers to: specs/package/Package.md:281 in 50e998b. [](commit_id = 50e998b, deletion_comment = False)

[letao-msft]

if (absoluteFilename == null)

The API returns empty string - does that really map to null in C#?
Consider using string.IsNullOrEmpty(absoluteFileName).

---

Refers to: specs/package/Package.md:285 in 50e998b. [](commit_id = 50e998b, deletion_comment = False)

[letao-msft]

    wprintf(L"ERROR: Microsoft.UI.Xaml.winmd not found\n", hr);

There is no % specifier that matches this argument.

---

Refers to: specs/package/Package.md:356 in 50e998b. [](commit_id = 50e998b, deletion_comment = False)

[letao-msft]

    wprintf(L"ERROR: resources.pri not found for %ls\n", hr, packageFullName);

There is no % specifier that matches this argument

---

Refers to: specs/package/Package.md:262 in 50e998b. [](commit_id = 50e998b, deletion_comment = False)

[letao-msft]

    wprintf(L"ERROR: resources.pri not found for %ls\n", hr, packageFullName);

There is no % specifier that matches this argument

---

Refers to: specs/package/Package.md:312 in 50e998b. [](commit_id = 50e998b, deletion_comment = False)

[letao-msft]

    wprintf(L"ERROR: Microsoft.UI.Xaml.winmd not found\n", hr);

There is no % specifier that matches this argument

---

Refers to: specs/package/Package.md:412 in 50e998b. [](commit_id = 50e998b, deletion_comment = False)

[letao-msft]

std::wstring GetResourcesPri(PCWSTR packageFullName)

This parameter is never used

---

Refers to: specs/package/Package.md:205 in 50e998b. [](commit_id = 50e998b, deletion_comment = False)

[DrusTheAxe]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).