chore(server): Upgrade server Dockerfiles to Node 22#27074
Open
ChumpChief wants to merge 1 commit intomicrosoft:mainfrom
Open
chore(server): Upgrade server Dockerfiles to Node 22#27074ChumpChief wants to merge 1 commit intomicrosoft:mainfrom
ChumpChief wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Updates the base image in routerlicious, historian, and gitrest Dockerfiles from node:20.19.0-bookworm-slim to node:22.22.2-bookworm-slim with pinned sha256 digest. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChumpChief
force-pushed
the
server-dockerfiles-node22-v2
branch
2 times, most recently
from
8a99290 to
8aa5710
Compare
Contributor
Author
|
I struggled to figure out how to get an accurate manual run of the end to end tests pre checkin, but I think we have a good handle on why it failed before. If it fails again after merge then we can revert again. Filed AB#70628 for facilitating manual runs against builds from test branches |
ChumpChief
requested review from
alexvy86,
Copilot,
sonalideshpandemsft and
znewton
Contributor
There was a problem hiding this comment.
Pull request overview
Updates server container base images to align runtime with the repo’s Node 22 toolchain requirement, ensuring routerlicious services build/run on the pinned Node 22.22.2 Bookworm slim image.
Changes:
- Bump
FROM node:20.19.0-bookworm-slim@...tonode:22.22.2-bookworm-slim@...(pinned by sha256 digest) for routerlicious, historian, and gitrest images.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/routerlicious/Dockerfile | Switch runner/build base image to Node 22.22.2 (pinned digest). |
| server/historian/Dockerfile | Switch runner/build base image to Node 22.22.2 (pinned digest). |
| server/gitrest/Dockerfile | Switch runner/build base image to Node 22.22.2 (pinned digest). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the base image in the routerlicious, historian, and gitrest Dockerfiles from
node:20.19.0-bookworm-slimtonode:22.22.2-bookworm-slimwith a pinned sha256 digest.This is a re-land of #26998, which was reverted due to a startup race condition between
riddler and gitrest. That issue has been fixed in #27069 by adding retry logic to riddler's
getOrCreateRepositorycall.The gitssh Dockerfile uses Alpine (no Node) and does not require changes.
Reviewer Guidance
The review process is outlined on this wiki page.