chore: Enhance deployment guides and improve OneLake data source creation#133
Draft
Harmanpreet-Microsoft wants to merge 1 commit intomicrosoft:mainfrom
Draft
Conversation
…tion - Expanded docs for BYO Fabric mode (capacity + workspace reuse) - Updated main.bicepparam to read Fabric IDs from environment variables - Persist lakehouse IDs via azd env in create_lakehouses.ps1 - Improved 04_create_onelake_datasource.ps1 to resolve workspace/lakehouse IDs from multiple sources Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Harmanpreet-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801 and
toherman-msft
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant improvements to the configuration and automation of Microsoft Fabric resource deployment, especially around "bring your own" (BYO) scenarios. The changes enhance environment variable management, clarify documentation, and improve the robustness of resource ID handling across deployment scripts.
Key changes:
Documentation and Configuration Improvements
docs/parameter_guide.mdanddocs/deploymentguide.mdto clearly explain the different Fabric deployment modes (create,byo,none), how to configure them via environment variables, and step-by-step instructions for BYO scenarios. This includes guidance on setting and discovering required resource IDs and workspace GUIDs. [1] [2]fabricCapacityModeenvironment variable is the primary control point for both capacity and workspace presets, and that BYO inputs are now expected as environment variables.Environment Variable Handling in Bicep
infra/main.bicepparamto readfabricCapacityResourceId,fabricWorkspaceId, andfabricWorkspaceNamedirectly from environment variables (usingreadEnvironmentVariable), improving flexibility and alignment with deployment practices.Automation Script Enhancements
create_lakehouses.ps1to persist lakehouse IDs into the azd environment store after creation, enabling downstream scripts and reruns to reliably locate existing lakehouses.04_create_onelake_datasource.ps1to robustly resolve workspace and lakehouse IDs by checking azd outputs, the azd environment store, and fallback temp files, ensuring compatibility with both BYO and newly created resources.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information