Update arexx_ml.c - Sensor with longer than 4 hex digits ID can't be proceed#3488
Open
inonoob wants to merge 1 commit intomerbanan:masterfrom
Open
Update arexx_ml.c - Sensor with longer than 4 hex digits ID can't be proceed#3488inonoob wants to merge 1 commit intomerbanan:masterfrom
inonoob wants to merge 1 commit intomerbanan:masterfrom
Conversation
Found sensor TSN-TH70E which are longer than 16 bits
Author
|
Here in addition from the MQTT server to Home assistant. It seems to work fine. |
Collaborator
|
The cases for length == 6 and the handling for TL-3TSN, TSN-33MN seem to have been removed? Is that intentional? |
Author
|
Nope was not intentional... I took this version of the code .... my bad... Therefore the part with TL-3TSN, TSN-33MN is missing.... |
Owner
|
@inonoob can you post a sample file so that this change can be tested? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found sensor with longer ID compare to current implemented one
I bought an additional TSN-TH70E which already has been implemented in RTL_433. But it turned out that this sensor has a longer ID than the usual. This is case it was 199196.
I check with RTL_433 the raw data
{121}d55555552a838e8501a002e487f8000I did remember the following discussion about decoding the message:
#2482 (comment)
as you can see the code is different:
Once shifted left we have the following message
Here you can see below the new message from the sensor:
aaaaaaaa 55 07 1d0a03 40 05c9 0f f0000The new code is now showing a longer id with front 0 for ID which are shorter than 0x- - - -
I did test it on my machine and see good results:
Two sensors next to each other for Humdity:
here for Temperature:
It seems the message length capture for the sensor with the longer ID has a shorter message length {121} vs {137}. See above with the two examples
I used AI to craft the code as my C programing skill are near 0. So feedback would be appreciated.
If more information are needed or even more example please let me know.