Skip to content

Add Laravel 13 and PHP 8.4 support #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tranKILL wants to merge 1 commit into from
+15 −8
Closed

Add Laravel 13 and PHP 8.4 support #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ jobs:
fail-fast: true
matrix:
os: [ubuntu-latest]
php: [8.3, 8.2, 8.1]
laravel: [10.*, 11.*, 12.*]
php: [8.4, 8.3, 8.2, 8.1]
laravel: [10.*, 11.*, 12.*, 13.*]
stability: [prefer-lowest, prefer-stable]
include:
- laravel: 10.*
Expand All @@ -30,17 +30,24 @@ jobs:
- laravel: 12.*
testbench: 10.*
carbon: ^3.0
- laravel: 13.*
testbench: 11.*
carbon: ^3.0
exclude:
- laravel: 10.*
php: 8.4
- laravel: 11.*
php: 8.1
- laravel: 12.*
php: 8.1
- laravel: 13.*
php: 8.1

name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }}

steps:
- name: Checkout code
uses: actions/checkout@v5
uses: actions/checkout@v6

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
10 changes: 5 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@
}
],
"require": {
"php": "^8.1 | ^8.2 | ^8.3",
"illuminate/contracts": "^10.0 | ^11.0 | ^12.0",
"php": "^8.1 | ^8.2 | ^8.3 | ^8.4",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PHP version constraint is redundant. The caret operator (^8.1) already covers all minor versions within the 8.x range, including 8.2, 8.3, and 8.4. Explicitly listing each minor version increases maintenance overhead without providing additional functional constraints.

Suggested change
"php": "^8.1 | ^8.2 | ^8.3 | ^8.4",
"php": "^8.1",

"illuminate/contracts": "^10.0 | ^11.0 | ^12.0 | ^13.0",
"spatie/laravel-package-tools": "^1.16.0"
},
"require-dev": {
"laravel/pint": "^1.0",
"mockery/mockery": "^1.6",
"nunomaduro/collision": "^7.8 | ^8.1",
"orchestra/workbench": "^8.0 | ^9.0 | ^10.0",
"phpunit/phpunit": "^10.5 | ^11.0",
"nunomaduro/collision": "^7.8 | ^8.1 | ^9.0",
"orchestra/workbench": "^8.0 | ^9.0 | ^10.0 | ^11.0",
"phpunit/phpunit": "^10.5 | ^11.0 | ^12.0",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Upgrading to PHPUnit 12 requires updating the phpunit.xml.dist configuration file. The current file uses the PHPUnit 10.3 schema, which is outdated for version 12 and may lead to configuration errors or ignored settings. The schema and configuration structure should be updated to match PHPUnit 12 requirements.

"rector/rector": "^2.1.7"
},
"autoload": {
Expand Down