fix: address PR #100 follow-up feedback — typos, layout, shortcode rename#107
Open
fix: address PR #100 follow-up feedback — typos, layout, shortcode rename#107
Conversation
…e rename - Swap "Join Clients Like" heading below the descriptive paragraph so the label sits directly above the client logo carousel (Megan feedback) - Drop leading "and" from step #4 in the audit CTA list for consistent style - Fix "iac-sound-familier" typo → "iac-sound-familiar" in frontmatter + CSS - Rename accordian.html → accordion.html shortcode and update usage Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for masterpoint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
WalkthroughFixes typos across multiple files, correcting "familier" to "familiar" and "accordian" to "accordion", and reorders a section heading. No logic or functionality is modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
layouts/shortcodes/accordion.html (1)
5-5: Prefer a<button>trigger overhref="javascript:void(0)".This improves semantics and enables proper keyboard support and ARIA attributes for accordion toggle controls.
♻️ Proposed refactor
- <h3 class="faqQ"> - <a href="javascript:void(0)">{{ $faq.title }}</a> - </h3> + <h3 class="faqQ"> + <button type="button" class="faq-toggle">{{ $faq.title }}</button> + </h3>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@layouts/shortcodes/accordion.html` at line 5, Replace the non-semantic anchor used as the accordion trigger (<a href="javascript:void(0)">{{ $faq.title }}</a>) with a proper <button type="button"> trigger in the accordion shortcode, and wire up accessible attributes: move the text "{{ $faq.title }}" into the button, add aria-expanded="false" (toggle to true/false on click), add aria-controls pointing to the associated panel id, and ensure the panel has a matching id and role="region" or aria-hidden toggled; update any JS that queries the anchor selector to target the button instead so keyboard and screen-reader interaction works correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@layouts/shortcodes/accordion.html`:
- Line 5: Replace the non-semantic anchor used as the accordion trigger (<a
href="javascript:void(0)">{{ $faq.title }}</a>) with a proper <button
type="button"> trigger in the accordion shortcode, and wire up accessible
attributes: move the text "{{ $faq.title }}" into the button, add
aria-expanded="false" (toggle to true/false on click), add aria-controls
pointing to the associated panel id, and ensure the panel has a matching id and
role="region" or aria-hidden toggled; update any JS that queries the anchor
selector to target the button instead so keyboard and screen-reader interaction
works correctly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ed00fb11-8210-4366-9229-8e9f1be7eddf
📒 Files selected for processing (7)
assets/css/custom.scsscontent/sections/home-join-clients.mdcontent/sections/home-turn-chaos.mdcontent/sections/iac-questions.mdcontent/sections/iac-sound-familiar.mdlayouts/shortcodes/accordian.htmllayouts/shortcodes/accordion.html
💤 Files with no reviewable changes (1)
- layouts/shortcodes/accordian.html
oycyc
reviewed
Apr 11, 2026
Contributor
There was a problem hiding this comment.
gberenice
reviewed
Apr 14, 2026
Member
gberenice
left a comment
gberenice
left a comment
There was a problem hiding this comment.
@Gowiem what do you think about my second suggestion here #100 (comment)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Follow-up fixes from team feedback on PR #100 (homepage redesign + IAC audit page):
iac-sound-familier→iac-sound-familiarin both the content section ID and the matching CSS selectoraccordian.html→accordion.htmland updated the shortcode call iniac-questions.mdwhy
references
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation