Skip to content

release: 8.2617.111#2737

Open
chiol wants to merge 13 commits intomainfrom
dev
Open

release: 8.2617.111#2737
chiol wants to merge 13 commits intomainfrom
dev

Conversation

@chiol
Copy link
Copy Markdown
Contributor

@chiol chiol commented Apr 21, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Fixed channel initialization logic in the feedback section to prevent unnecessary state updates.
  • Chores

    • Updated Node.js runtime to version 24.14.1 across all services.
    • Updated AWS SDK, validation libraries, testing utilities, and data-fetching dependencies to latest versions.

renovate bot and others added 13 commits March 24, 2026 02:33
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…2732)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…2736)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@chiol chiol requested a review from jihun April 21, 2026 04:48
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 21, 2026

Walkthrough

This PR updates the Node.js runtime version from 24.14.0 to 24.14.1 across configuration files and Docker images, bumps dependency versions in app-specific package.json files, and refines conditional logic in a React useEffect hook for channel initialization.

Changes

Cohort / File(s) Summary
Node.js Runtime Version Bump
.nvmrc, package.json, docker/api.dockerfile, docker/docs.dockerfile, docker/web.dockerfile
Updated Node.js version from 24.14.0 to 24.14.1 consistently across runtime configuration, root engine requirements, and all Docker base images.
Dependency Version Bumps
apps/api/package.json
Bumped @aws-sdk/client-s3 and @aws-sdk/s3-request-presigner from ^3.1014.0 to ^3.1015.0, upgraded joi from ^18.0.2 to ^18.1.1, and increased @faker-js/faker from ^10.3.0 to ^10.4.0.
Dependency Version Bumps
apps/web/package.json
Upgraded @faker-js/faker from ^10.3.0 to ^10.4.0 and bumped @tanstack/react-query and @tanstack/react-query-devtools from ^5.95.0 to ^5.95.2.
useEffect Logic Refinement
apps/web/src/pages/main/project/[projectId]/feedback.tsx
Enhanced conditional logic in the channel initialization effect to return early when channels is unavailable OR currentChannelId is already set (non-initial value). Expanded dependency array from [channels] to [channels, currentChannelId].

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • update aws-sdk package #1341: Updates overlapping AWS SDK dependencies (@aws-sdk/client-s3 and @aws-sdk/s3-request-presigner) in apps/api/package.json.
  • release: 8.2537.106 #2055: Performs similar Node.js version and dependency bumps across core configuration and Docker files.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'release: 8.2617.111' is a version release tag that doesn't describe the actual changes made in the pull request. The PR updates Node.js version, dependency versions, and Docker images, but the title provides no information about these changes. Use a more descriptive title that reflects the actual changes, such as 'chore: update Node.js to 24.14.1 and bump dependencies' to clearly communicate the purpose of the release.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
apps/web/src/pages/main/project/[projectId]/feedback.tsx (1)

50-53: Guard prevents re-initialization after user channel selection — looks correct.

The early-return on currentChannelId !== -1 avoids overwriting the user's selection when channels refetches, and including currentChannelId in the dep array is consistent with the new conditional. No infinite loop risk since the effect is a no-op once a valid id is set.

Minor edge case to be aware of (not blocking): if the currently selected channel is deleted server-side and channels refetches, the stale currentChannelId will persist and the page falls through to the "Channel is invalid" UI in FeedbackContainer. That's an acceptable UX, but if you'd prefer to auto-recover, you could additionally reset when currentChannelId is not present in channels.items.

♻️ Optional recovery for deleted channel
   useEffect(() => {
-    if (!channels || currentChannelId !== -1) return;
-    void setCurrentChannelId(channels.items[0]?.id ?? null);
+    if (!channels) return;
+    const exists = channels.items.some((c) => c.id === currentChannelId);
+    if (currentChannelId !== -1 && exists) return;
+    void setCurrentChannelId(channels.items[0]?.id ?? null);
   }, [channels, currentChannelId]);
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/pages/main/project/`[projectId]/feedback.tsx around lines 50 -
53, The effect currently prevents overwriting a user-selected channel by
early-returning when currentChannelId !== -1; to auto-recover when that channel
is deleted server-side, update the useEffect to also detect if currentChannelId
is non-null but not present in channels.items and reset via setCurrentChannelId
to the first available channel id (or null) — reference the existing useEffect,
variables channels, currentChannelId, and setter setCurrentChannelId (and keep
the dependency array as [channels, currentChannelId]).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/web/src/pages/main/project/`[projectId]/feedback.tsx:
- Around line 50-53: The effect currently prevents overwriting a user-selected
channel by early-returning when currentChannelId !== -1; to auto-recover when
that channel is deleted server-side, update the useEffect to also detect if
currentChannelId is non-null but not present in channels.items and reset via
setCurrentChannelId to the first available channel id (or null) — reference the
existing useEffect, variables channels, currentChannelId, and setter
setCurrentChannelId (and keep the dependency array as [channels,
currentChannelId]).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 02b1b592-7b87-422f-af5c-e57bc759d33f

📥 Commits

Reviewing files that changed from the base of the PR and between 8f95c48 and 66f6dc7.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (8)
  • .nvmrc
  • apps/api/package.json
  • apps/web/package.json
  • apps/web/src/pages/main/project/[projectId]/feedback.tsx
  • docker/api.dockerfile
  • docker/docs.dockerfile
  • docker/web.dockerfile
  • package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant