fix!: change return type on Parse method#37
Open
lewismiddleton wants to merge 1 commit intoleodido:developfrom
Open
fix!: change return type on Parse method#37lewismiddleton wants to merge 1 commit intoleodido:developfrom
lewismiddleton wants to merge 1 commit intoleodido:developfrom
Conversation
Changes the return type on the `Machine.Parse` method to return a ConventionalCommit object. This gives the type system more information on the properties available. We still get the type information from the `Message` interface because ConventionalCommit implements Message so no functionality is lose. However this is does change the return types for all consumers using the Parse method. BREAKING CHANGE: `Machine.Parse()` method now returns ConventionalCommit object instead of Message
lewismiddleton
force-pushed
the
parse-return-type
branch
from
8aa3fe6 to
82785f5
Compare
Author
|
Ah I see from the build that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the return type on the
Machine.Parsemethod to return a ConventionalCommit object. This gives the type system more information on the properties available.We still get the type information from the
Messageinterface because ConventionalCommit implements Message so no functionality is lost. However this does change the return types for all consumers using the Parse method.BREAKING CHANGE:
Machine.Parse()method now returns ConventionalCommit object instead of MessageResolves: #36