Fix: resolve broken Join Now button in Events section#7641
Open
atharvachavan289-gif wants to merge 1 commit intolayer5io:masterfrom
Open
Fix: resolve broken Join Now button in Events section#7641atharvachavan289-gif wants to merge 1 commit intolayer5io:masterfrom
atharvachavan289-gif wants to merge 1 commit intolayer5io:masterfrom
Conversation
Signed-off-by: atharvachavan989-debug <atharvachavan989@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed the transient prop
$from the$urlprop in the Button component to ensure the link actually registers on the HTML element.This PR fixes #7623
Notes for Reviewers
The button link logic is fixed. (Note: My local Windows environment was failing to build the
sharpimage module, so I will be using the automated Deploy Preview to verify if my CSS layout changes successfully fixed the desktop image misalignment!).Signed commits