-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix ConcurrentMapNative snapshot views to avoid CME during iteration #5504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dapzthelegend
wants to merge
3
commits into
ktorio:main
Choose a base branch
from
dapzthelegend:fix/concurrent-map-entries-5480
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+106
−3
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
ktor-utils/posix/test/io/ktor/util/collections/ConcurrentMapNativeTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /* | ||
| * Copyright 2014-2025 JetBrains s.r.o and contributors. Use of this source code is governed by the Apache 2.0 license. | ||
| */ | ||
|
|
||
| package io.ktor.util.collections | ||
|
|
||
| import kotlin.test.* | ||
|
|
||
| class ConcurrentMapNativeTest { | ||
|
|
||
| @Test | ||
| fun `entries returns snapshot`() { | ||
| val map = ConcurrentMap<Int, String>(initialCapacity = 4) | ||
| map[1] = "one" | ||
| map[2] = "two" | ||
|
|
||
| val entries = map.entries | ||
| map.remove(1) | ||
| map[3] = "three" | ||
|
|
||
| assertEquals(listOf(1 to "one", 2 to "two"), entries.map { it.key to it.value }.sortedBy { it.first }) | ||
| } | ||
|
|
||
| @Test | ||
| fun `keys returns snapshot`() { | ||
| val map = ConcurrentMap<Int, String>(initialCapacity = 4) | ||
| map[1] = "one" | ||
| map[2] = "two" | ||
|
|
||
| val keys = map.keys | ||
| map.remove(1) | ||
| map[3] = "three" | ||
|
|
||
| assertEquals(setOf(1, 2), keys.toSet()) | ||
| } | ||
|
|
||
| @Test | ||
| fun `values returns snapshot`() { | ||
| val map = ConcurrentMap<Int, String>(initialCapacity = 4) | ||
| map[1] = "one" | ||
| map[2] = "two" | ||
|
|
||
| val values = map.values | ||
| map.remove(1) | ||
| map[3] = "three" | ||
|
|
||
| assertEquals(listOf("one", "two"), values.sorted()) | ||
| } | ||
|
|
||
| @Test | ||
| fun `entries snapshot supports value-based contains and remove`() { | ||
| val map = ConcurrentMap<Int, String>(initialCapacity = 4) | ||
| map[1] = "one" | ||
| map[2] = "two" | ||
|
|
||
| val entries = map.entries | ||
| assertTrue(entries.contains(TestMutableEntry(1, "one"))) | ||
| assertTrue(entries.remove(TestMutableEntry(1, "one"))) | ||
| assertFalse(entries.contains(TestMutableEntry(1, "one"))) | ||
| } | ||
| } | ||
|
|
||
| private class TestMutableEntry<K, V>( | ||
| override val key: K, | ||
| override val value: V | ||
| ) : MutableMap.MutableEntry<K, V> { | ||
| override fun setValue(newValue: V): V = value | ||
|
|
||
| override fun equals(other: Any?): Boolean { | ||
| if (other !is Map.Entry<*, *>) return false | ||
| return key == other.key && value == other.value | ||
| } | ||
|
|
||
| override fun hashCode(): Int = key.hashCode() xor value.hashCode() | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.