Merged
Conversation
- Fix TLV loop off-by-one: use >= so zero-length TLVs at buffer tail are processed - Fix uint16_t overflows in pp_info_add_aws_vpce_id, pp_info_add_netns, tlv_array_append_tlv_new_usascii - Fix SSL sub-TLV bounds: require full header before read, validate sub-TLV length, reject trailing bytes - Fix uint16_t overflow in pp2_tlv_offset: use uint32_t to prevent infinite loop on large TLV lengths - Fix SSL TLV minimum length check: validate pp2_tlv_len >= 5 before accessing fields - Fix NOOP padding heap overflow: add padding_bytes > 0 guard - Fix v1 parser: change || to && for UNKNOWN header, use PP1_MAX_LENGTH - 1 to preserve null terminator - Add NULL checks in pp_info_add_netns and pp_info_add_aws_vpce_id - Eliminate switch fallthrough and remove -Wimplicit-fallthrough=0 from Makefile for portability - Refactor Azure parser to use tlv_array_append_tlv_new() wrapper - Add explicit casts for pointer subtraction and strlen results to suppress MSVC 64-bit warnings - Add 5 unit tests for TLV overflow, SSL too short, SSL trailing bytes, v1 invalid family, v1 no CRLF
kosmas-valianos
changed the title
- Fix uint16_t overflow in pp2_create_hdr: accumulate TLV lengths in uint32_t, check > UINT16_MAX before truncating - Fix memory leak in test harness: free raw_bytes_in buffer after pp_parse_hdr - Fix MSVC C4244 warning: cast _sprintf return to uint16_t in pp1_create_hdr - Fix parse_port: reject leading + prefix and trailing non-digit characters - Add tests for parse_port strictness (+ prefix, trailing garbage) and pp_info_add_* NULL/length guards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.