Merged
Conversation
* Add support for the SSL client certificate TLV * Add support for the SSL-related TLVs for key exchange group and signature * Add missing unit tests for some types
Bugs: - cert_in_connection << 2 changed to cert_in_session << 2 in pp_info_add_ssl() - Added NULL check after malloc() in pp_info_add_ssl(), returns 0 on failure - Added NULL check after malloc() in pp_info_add_aws_vpce_id(), returns 0 on failure - Added NULL check after malloc() in pp_info_add_azure_linkid(), returns 0 on failure - Added minus sign to 4 error return statements in v1 address parsing (ERR_PP1_IPV4_SRC_IP, ERR_PP1_IPV6_SRC_IP, ERR_PP1_IPV4_DST_IP, ERR_PP1_IPV6_DST_IP) - Split the if (!tlv || !tlv_array_append_tlv()) condition in tlv_array_append_tlv_new() and tlv_array_append_tlv_new_usascii() so that tlv is freed when append fails - Moved tlv_array->size += 5 after the realloc success check, using (tlv_array->size + 5) in the realloc call itself Robustness: - parse_port() now accepts port 0 using endptr from strtoul to distinguish "0" from invalid input - Added length checks (> 5) before memcpy into 6-byte port string buffers to prevent buffer overflow on malformed v1 input - AF_UNIX parsing now advances buffer and sets tlv_vectors_len so TLVs after UNIX addresses are parsed Style: - PP1_MAX_LENGHT renamed to PP1_MAX_LENGTH - Removed double semicolons at two locations - Inpects changed to Inspects in proxy_protocol.h - ALl changed to All in test.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.