Skip to content

Add Zstd compression and improve compression configuration#991

Open
DRSchlaubi wants to merge 6 commits intomainfrom
feature/zstd
Open

Add Zstd compression and improve compression configuration#991
DRSchlaubi wants to merge 6 commits intomainfrom
feature/zstd

Conversation

@DRSchlaubi
Copy link
Copy Markdown
Member

This PR has 2 goals:

  • Add support for Zstd
  • Add proper compression configuration

Currently there is no real way to disable compression, the un-documented way is to remove the compress parameter from the gateway url, this PR adds a compression property to the relevant builders

val kord = Kord(token) {
  compression = Compression.Zstd
}

DRSchlaubi and others added 2 commits November 6, 2024 17:36
@greg6775
Copy link
Copy Markdown

any updates on this @DRSchlaubi ?

@DRSchlaubi
Copy link
Copy Markdown
Member Author

any updates on this @DRSchlaubi ?

Still waiting on @lukellmann

@lukellmann
Copy link
Copy Markdown
Member

I've been busy with other things recently, can't promise when I'll have time to look into this.

@MayaChen350
Copy link
Copy Markdown
Contributor

Any updates on this

Copy link
Copy Markdown
Contributor

@NoComment1105 NoComment1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, some small merge conflicts to fix first. @lukellmann would you still like to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants