[MTA-4033] Put gradle task in a better place#141
Conversation
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
WalkthroughThe Dockerfile was updated to change the destination path where the Gradle build file is copied during the image build process. The file is now placed in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Dockerfile (2)
39-42: Minor: align the explanatory comment with the new destinationThe comment at Line 39 still implies the file is copied into the Gradle user-home. Consider updating it so future readers don’t wonder why we create
/root/.gradlebut write the task elsewhere.-# Copy "download sources" gradle task. This is needed to download project sources. +# Copy the "download sources" Gradle task (used by the analyzer) into a +# shared location inside the image.
40-41: Clean-up: remove the now-unused/root/.gradledirectory if not requiredIf the sole purpose of
/root/.gradlewas to hosttask.gradle, theRUN mkdir /root/.gradleline can be dropped.
Keeping it is harmless but increases layer size and may confuse maintainers. Verify whether Gradle actually needs a pre-created user-home in this image.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(1 hunks)
🔇 Additional comments (1)
Dockerfile (1)
39-42: No stale references to the old task.gradle path foundI searched the entire repository for any hard-coded references to the old
/root/.gradle/task.gradlelocation—including both “.gradle/task.gradle” and explicit-b task.gradleflags—and none were found. No further changes are needed.
https://issues.redhat.com/browse/MTA-4033 https://issues.redhat.com/browse/MTA-3780 #869 Requires: - konveyor/java-analyzer-bundle#141 Bundle PR: 141 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added support for specifying a custom Gradle sources task file path through a new configuration option. * **Refactor** * Gradle cache directory is now determined dynamically based on environment variables, improving compatibility across different setups. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
https://issues.redhat.com/browse/MTA-4033
konveyor/analyzer-lsp#869
Summary by CodeRabbit