Update tests for initialValues for Checkbox component#380
Open
jetpack3331 wants to merge 3 commits intokettanaito:masterfrom
Open
Update tests for initialValues for Checkbox component#380jetpack3331 wants to merge 3 commits intokettanaito:masterfrom
jetpack3331 wants to merge 3 commits intokettanaito:masterfrom
Conversation
kettanaito
approved these changes
Apr 30, 2019
Owner
kettanaito
left a comment
kettanaito
left a comment
There was a problem hiding this comment.
Great job! Thank you.
I would need to run the tests locally to verify, and then we can merge.
Contributor
Author
|
Sure :) let me know if you will solve the problem with local cypress |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for initialValues had missing Checkbox values (Bool) so it needs to be added to the tests.