Draft
Conversation
Owner
|
Icons look good I think. Fits in with the philosophy of "magit, but in a way that fits in the ecosystem and plays on the strengths of vscode". |
Contributor
Author
|
Thanks for the feedback! I plan to pick this up again in around 3-4 weeks. |
danilonovaisv
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like icons in my menus and I cannot lie - after adding some ~600 icons to VSpaceCode, I took a look at edamagit next.
A few examples on how this looks with my config:
Details
(Yay, giant screenshots again - I always forgot that I'm on a 4k screen and zoom in way too much)
Before I continue with this and try to find more icons, I thought I'd get some feedback - what do you think? Does this sound reasonable? Should this be an option or just hardcoded like now?
I guess sometimes it can be hard to find matching icons, and I haven't looked at most of the commented out commands yet. Often, however, it's surprisingly possible to find something in the giant list of icons with some creativity.