Conversation
|
tsaglam
left a comment
tsaglam
left a comment
There was a problem hiding this comment.
Reminder for us: This is a breaking change, merge only after next minor release.
There was a problem hiding this comment.
Pull Request Overview
This PR creates a new reporting module by extracting reporting-related functionality from the core module. The purpose is to better organize the codebase by separating reporting utilities into their own module while maintaining proper dependencies (reporting -> core, cli -> reporting, cli -> core).
- Moves all CSV, JSON factory, and report object classes from core to the new reporting module
- Updates package declarations and import statements across affected files
- Adjusts test classes to manually build JPlag options since core test utilities are no longer available
Reviewed Changes
Copilot reviewed 32 out of 50 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| reporting/pom.xml | Creates new reporting module with dependency on core and test dependency on java language |
| reporting/src/main/java/de/jplag/reporting/csv/* | Updates package declarations from de.jplag.csv to de.jplag.reporting.csv |
| reporting/src/main/java/de/jplag/reporting/jsonfactory/* | Updates imports to use core's FilePathUtil instead of reporting's |
| reporting/src/test/java/de/jplag/reporting/reportobject/* | Refactors tests to manually create JPlag options and use getFirst() instead of get(0) |
| core/src/main/java/de/jplag/* | Moves FilePathUtil and Version classes to core package and updates serializer package locations |
| cli/src/main/java/de/jplag/cli/* | Updates imports to reference new reporting module locations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
tsaglam
left a comment
tsaglam
left a comment
There was a problem hiding this comment.
Ah, right, I am still blocking this. This is not a review, just to unblock it.
There was a problem hiding this comment.
check if this and the other serializer can be moved into the reporting package by injecting it at runtime or something similar using jackson
# Conflicts: # core/src/main/java/de/jplag/serializer/AllCapsClassNameSerializer.java
|
|
|
@TwoOfTwelve can you look at the sonar issues |
Moves all reporting related classes to a new module (#2531).
The following module dependencies are relevant for the new reporting module:
reporting -> core
cli -> reporting
cli -> core
Due to some dependencies not being available some tests had to be adjusted:
Some warnings in the moved code have been fixed