Preserve typing args when inspecting custom types#687
Open
dcwatson wants to merge 1 commit intojcrist:mainfrom
Open
Preserve typing args when inspecting custom types#687dcwatson wants to merge 1 commit intojcrist:mainfrom
dcwatson wants to merge 1 commit intojcrist:mainfrom
Conversation
|
this is very useful, why wasn't it merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other inspected types carry through the typing args, seems like custom types should as well. My specific use-case is wanting to use
msgspec.inspect.type_infoonStructs which may have customGenericmembers, without having to augment it with a separate call tomsgspec.structs.fieldsand parsing out the type info myself.