Open
Conversation
Use a version of ngrok which runs on recent versions of Windows and MacOS. Switch to using the npm `overrides` property, to avoid needing to mantain a separate fork of `zuul-ngrok`
Author
|
Note: merging this pull request separately may cause conflicts with other pull requests I've raised. I'd recommend only merging #837, which combines several upgrades in a single place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job
browser-usageappears to be consistently failing in github actions.I've found that upgrading some dependencies fixes it. But I'm not entirely sure what the underlying cause it. Through trial & error, I've reach this set of upgrades as the minimal needed to get all the tests passing again.
(Fixes #832 )
(Supersedes #833)