Partial Rendering Clarification - Documentation, Question#635
Open
brian-lim-42 wants to merge 2 commits intojanl:masterfrom
Open
Partial Rendering Clarification - Documentation, Question#635brian-lim-42 wants to merge 2 commits intojanl:masterfrom
brian-lim-42 wants to merge 2 commits intojanl:masterfrom
Conversation
Collaborator
|
@bhldev Hi! Looks pretty good to me. Maybe adding the actual output of the sample, for clarity? Cheers! |
Author
|
Updated pull with example 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following code snippet shows issue
This does not render 4 and 5 as expected with nested views a la common web view engines (documentation is exacting, "thought of as one single template" is literal)
Updated documentation to reflect this
Is there appetite for contexts ? I could pull request a non-breaking option for nested partial support... I do not want to switch to handlebars for such a basic functionality unless I have to
Thanks
~ B