Try to end /api/atelier web sessions when extension deactivates#267
Merged
gjsjohnmurray merged 3 commits intointersystems-community:masterfrom Apr 30, 2025
Merged
Conversation
gjsjohnmurray
commented
Apr 28, 2025
Collaborator
Author
gjsjohnmurray
left a comment
gjsjohnmurray
left a comment
There was a problem hiding this comment.
I will now investigate making a similar change in the ObjectScript extension.
Collaborator
|
@gjsjohnmurray I already have that code ready, I just didn't open the PR yet! I have it ready for the Language Server as well. I'm just waiting on Raj's approval. |
isc-bsaviano
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the extension try to end its /api/atelier web sessions when deactivating (e.g. exiting VS Code or running
Developer: Reload Window)