Web support#258
Merged
isc-bsaviano merged 2 commits intointersystems-community:masterfrom Mar 7, 2025
Merged
Conversation
gjsjohnmurray
approved these changes
Mar 7, 2025
Collaborator
gjsjohnmurray
left a comment
There was a problem hiding this comment.
Changes look good, and the dev VSIX is running fine on Desktop. I'm happy for it to be merged as is, despite the limitations you have described. It will be easier for me to test the behaviour in a browser once merged to master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #232 and fixes intersystems-community/vscode-objectscript#1491. I was able to get this extension to activate in the web, and almost all features work. However, there are two behavior differences that make this substantially less useful in the web:
II still think this is good enough to meet our needs, but I wanted to be fully transparent about the limitations in case you can't try it out yourself.