fix: retry_delay_ms reads from wrong config key (read_delay_ms)#3352
Closed
slymanmrcan wants to merge 1 commit intointegrations:mainfrom
Closed
fix: retry_delay_ms reads from wrong config key (read_delay_ms)#3352slymanmrcan wants to merge 1 commit intointegrations:mainfrom
slymanmrcan wants to merge 1 commit intointegrations:mainfrom
Conversation
retry_delay_ms was incorrectly reading from 'read_delay_ms' key instead of 'retry_delay_ms', causing retry_delay_ms config to be silently ignored.
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Collaborator
|
Duplicate of #3247 |
Author
|
Sorry for the duplicate, closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
retry_delay_msis being read from the wrong config key.Currently it reads from
read_delay_msinstead ofretry_delay_ms.This means the
retry_delay_msconfiguration is silently ignoredand always takes the value of
read_delay_ms.Fix
Changed
d.Get("read_delay_ms")tod.Get("retry_delay_ms")for the
retryDelayvariable.