refactor: migrate resource_github_issue_label to context-aware CRUD a…#3342
Open
slymanmrcan wants to merge 1 commit intointegrations:mainfrom
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Collaborator
|
Please remove the resolves comment, since it adresses the issue only partly. And "resolves" will close the issue |
deiga
approved these changes
Apr 18, 2026
Collaborator
deiga
left a comment
deiga
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for the contribution!
deiga
added
the
Type: Maintenance
Author
|
I just removed it from the description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses parts of #3070
Addresses parts of #2996
Before the change?
resource_github_issue_labeluses legacyCreate/Read/Update/Deleteschema functions and
log.Printffor logging.After the change?
CreateContext/ReadContext/UpdateContext/DeleteContext(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnosticslog.Printfwithtflog.Infofor structured loggingcontext.Background()callsdiag.FromErr()Pull request checklist
Does this introduce a breaking change?