Skip to content

refactor: migrate resource_github_actions_environment_variable to tflog #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
texasich wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −2
Open

refactor: migrate resource_github_actions_environment_variable to tflog #3325

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f11b655
refactor: migrate resource_github_actions_environment_variable to tflog
texasich Apr 9, 2026
7a882e5
fix: remove fmt.Sprintf from tflog call, use static message
texasich Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions github/resource_github_actions_environment_variable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ package github
import (
"context"
"errors"
"log"
"fmt"
"net/http"
"net/url"

"github.com/google/go-github/v84/github"
"github.com/hashicorp/terraform-plugin-log/tflog"
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)
Expand Down Expand Up @@ -140,7 +141,9 @@ func resourceGithubActionsEnvironmentVariableRead(ctx context.Context, d *schema
var ghErr *github.ErrorResponse
if errors.As(err, &ghErr) {
if ghErr.Response.StatusCode == http.StatusNotFound {
log.Printf("[INFO] Removing actions variable %s from state because it no longer exists in GitHub", d.Id())
tflog.Info(ctx, fmt.Sprintf("Removing actions variable %s from state because it no longer exists in GitHub", d.Id()), map[string]any{
Copy link
Copy Markdown
Collaborator

@deiga deiga Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use fmt.Sprintf inside tflog calls

"variable_id": d.Id(),
})
d.SetId("")
return nil
}
Expand Down