Skip to content

Updates to Next 14, fixing many minor issues #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brob wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updates to Next 14, fixing many minor issues #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6401ce
Updates to Next 14, fixing many minor issues
brob Aug 9, 2024
7282375
Removes yarn for deployments
brob Aug 9, 2024
d7e7f10
Fixes Options in footer
brob Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions components/blocks/columns/blog-post-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ export default function BlogPostCard({
<Text fontSize="sm" fontWeight="medium" color="indigo.600">
{startCase(category.toLowerCase())}
</Text>
<NextLink href={`/blog/${slug}`}>
<Link
href={`/blog/${slug}`}
display="block"
mt={2}
_hover={{
Expand All @@ -57,7 +57,6 @@ export default function BlogPostCard({
{excerpt}
</Text>
</Link>
</NextLink>
</Box>
<Flex alignItems="center" mt={6}>
<Stack
Expand Down
4 changes: 1 addition & 3 deletions components/button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,9 @@ export default function Button({ href, label, theme }) {

return (
<Box borderRadius="md" boxShadow="md">
<Link href={href} passHref>
<ChakraLink {...linkDefaultStyles} variant={theme}>
<ChakraLink href={href} {...linkDefaultStyles} variant={theme}>
{label}
</ChakraLink>
</Link>
</Box>
)
}
10 changes: 3 additions & 7 deletions components/footer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ function GridColumn({ links, title }) {
<Stack as="ul" mt={4} spacing={4}>
{links.map((link) => (
<li key={link.id}>
<Link href={`/${link.slug}`} passHref>
<ChakraLink
href={`/${link.slug}`}
color="gray.300"
_hover={{
color: 'white'
Expand All @@ -48,7 +48,6 @@ function GridColumn({ links, title }) {
{link.navigationLabel ||
link.slug.charAt(0).toUpperCase() + link.slug.slice(1)}
</ChakraLink>
</Link>
</li>
))}
</Stack>
Expand Down Expand Up @@ -131,15 +130,12 @@ export default function Footer({ primaryLinks, secondaryLinks }) {
onChange={setLocale}
>
{locales.map((locale) => (
<Box
as="option"
bg="#374151!important"
color="white"
<option
key={locale.value}
value={locale.value}
>
{locale.label}
</Box>
</option>
))}
</Select>
</Box>
Expand Down
2 changes: 1 addition & 1 deletion components/layout/site.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function PreviewBanner({ enabled = false }) {
<Box textAlign="center" p="2" backgroundColor="black" textColor="white">
Preview Mode Enabled (Content served from DRAFT) &mdash;&nbsp;
<Link href="/api/exit-preview">
<a>Exit Preview Mode</a>
Exit Preview Mode
</Link>
</Box>
)
Expand Down
10 changes: 2 additions & 8 deletions components/navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,8 @@ export default function Navigation({ pages }) {
<Flex alignItems="center" justifyContent="space-between">
<div>
<Link href="/">
<a>
<VisuallyHidden>Hygraph</VisuallyHidden>
<Box as={MarkSVG} h={8} w="auto" color="indigo.600" />
</a>
</Link>
</div>
<Box mr={-2}>
Expand Down Expand Up @@ -126,8 +124,8 @@ export default function Navigation({ pages }) {
const isActive = router.asPath.startsWith(`/${page.slug}`)

return (
<Link key={page.id} href={`/${page.slug}`} passHref>
<ChakraLink
key={page.id} href={`/${page.slug}`}
m={-3}
p={3}
display="flex"
Expand All @@ -150,7 +148,6 @@ export default function Navigation({ pages }) {
page.slug.slice(1)}
</Text>
</ChakraLink>
</Link>
)
})}
</Grid>
Expand All @@ -172,10 +169,8 @@ export default function Navigation({ pages }) {
>
<Flex w={{ lg: 0 }} flex={{ lg: '1 1 0' }}>
<Link href="/">
<a>
<VisuallyHidden>Hygraph</VisuallyHidden>
<Box as={LogoSVG} h={10} color="indigo.600" w="auto" />
</a>
</Link>
</Flex>
<Box mr={-2} my={-2} display={{ md: 'none' }}>
Expand Down Expand Up @@ -207,8 +202,8 @@ export default function Navigation({ pages }) {
const isActive = router.asPath.startsWith(`/${page.slug}`)

return (
<Link key={page.id} href={`/${page.slug}`} passHref>
<ChakraLink
key={page.id} href={`/${page.slug}`}
fontSize="md"
fontWeight="medium"
color={isActive ? 'indigo.600' : 'gray.500'}
Expand All @@ -219,7 +214,6 @@ export default function Navigation({ pages }) {
{page.navigationLabel ||
page.slug.charAt(0).toUpperCase() + page.slug.slice(1)}
</ChakraLink>
</Link>
)
})}
</Stack>
Expand Down
1 change: 1 addition & 0 deletions next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ module.exports = {
locales: locales.map((locale) => locale.value)
},
images: {
dangerouslyAllowSVG: true,
remotePatterns: [
{
protocol: 'https',
Expand Down
Loading