generate: drop stale num_return_sequences warning on continuous batching path#45582
Open
joaquinhuigomez wants to merge 3 commits intohuggingface:mainfrom
Open
generate: drop stale num_return_sequences warning on continuous batching path#45582joaquinhuigomez wants to merge 3 commits intohuggingface:mainfrom
joaquinhuigomez wants to merge 3 commits intohuggingface:mainfrom
Conversation
…ing path The continuous-batching branch warned that num_return_sequences was unsupported alongside num_beams, but generate_batch() already honors generation_config.num_return_sequences when expanding requests. The warning fires for any run that explicitly sets num_return_sequences even though the feature works, cluttering logs and misleading users. Drop the num_return_sequences half of the warning; keep the num_beams guard since beam search is still unsupported on the CB path. Fixes huggingface#45563
remi-or
approved these changes
Apr 23, 2026
Collaborator
remi-or
left a comment
remi-or
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix.
Collaborator
|
@bot /style |
Contributor
|
Style fix bot fixed some files and pushed the changes. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The continuous-batching branch in
generatewarned thatnum_return_sequenceswas unsupported alongsidenum_beams, butgenerate_batch()already honorsgeneration_config.num_return_sequenceswhen expanding requests. The warning fires for any run that explicitly setsnum_return_sequenceseven though the feature works, cluttering logs and misleading users.Drop the
num_return_sequenceshalf of the warning; keep thenum_beamsguard since beam search is still unsupported on the CB path.Fixes #45563