Fix whisper long-form generation when eos_token_id is a list#45570
Open
ronansgd wants to merge 1 commit intohuggingface:mainfrom
Open
Fix whisper long-form generation when eos_token_id is a list#45570ronansgd wants to merge 1 commit intohuggingface:mainfrom
ronansgd wants to merge 1 commit intohuggingface:mainfrom
Conversation
`generation_config.eos_token_id` can be `int | list[int]`, but the whisper long-form generation code compared it as a scalar in two places, causing silent wrong behavior or a RuntimeError. Normalize to a list and use membership checks instead of equality. Made-with: Cursor
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: whisper |
eustlb
reviewed
Apr 22, 2026
Contributor
eustlb
left a comment
eustlb
left a comment
There was a problem hiding this comment.
Hey @ronansgd, thanks for opening this PR!
- can you share a reproducer of the bug your describing? even better if you open an issue and reference it in this PR
- ideally we'd like to align whisper's custom generate to how it's handled in GenerationMixin's generate (so rather initializing an
eos_token_tensor). I have a commit ready to be pushed to this PR for that but I'm waiting for your reproducer first
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes: #45584
Fixes a bug in Whisper generation code, happening when
generation_config.eos_token_idis alist[int]and not anint(happens for instance afteralign_special_tokensis called inTrainer.train).Fix is to normalize to a list and use membership checks instead of equality.
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
cc @eustlb