Skip to content

fix(build): generate _routes.json based on public directory#270

Open
yusukebe wants to merge 2 commits intomainfrom
fix/build-routes-json-based-on-public
Open

fix(build): generate _routes.json based on public directory#270
yusukebe wants to merge 2 commits intomainfrom
fix/build-routes-json-based-on-public

Conversation

@yusukebe
Copy link
Copy Markdown
Member

Fixes #260

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 30, 2025

⚠️ No Changeset found

Latest commit: 3b10136

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@akku1139
Copy link
Copy Markdown

akku1139 commented May 31, 2025

Thank you @yusukebe for working on #260.

I did some checks.

The last one can be a problem when _worker.js uses env.ASSETS.fetch().

@yusukebe
Copy link
Copy Markdown
Member Author

@akku1139

Can you write a test for this?

When I delete a files/directories from public/, they will also be removed from dist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: _routes.json is not regenerated by emptyOutDir: false.

2 participants