Fix/db sync in dev mode & Fix/closeContainer undefined when RUNTIME_TYPE is not 'local-docker' #75
Open
SophiaJiaLi wants to merge 2 commits intohexdocom:mainfrom
Open
Fix/db sync in dev mode & Fix/closeContainer undefined when RUNTIME_TYPE is not 'local-docker' #75SophiaJiaLi wants to merge 2 commits intohexdocom:mainfrom
SophiaJiaLi wants to merge 2 commits intohexdocom:mainfrom
Conversation
Problem: When running in dev mode (pnpm run dev), sync.js is never called, leaving the database empty. All API calls fail with SQLITE_ERROR: no such table. Root cause: sync.js is only called in main.js (Electron entry), not in bin/www (Node dev entry). Fix: Call sync() in bin/www before server.listen() to ensure tables are created on startup.
… closeContainer was only assigned inside the if branch for 'local-docker', leaving it undefined in docker and other runtime modes. Added else branch to assign a no-op async function as fallback. closeContainer was only assigned inside the if branch for 'local-docker', leaving it undefined in docker and other runtime modes. Added else branch to assign a no-op async function as fallback.
Author
|
Problem2: closeContainer was only assigned inside the if branch for 'local-docker', Fix: Added else branch to assign a no-op async function as fallback. |
SophiaJiaLi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem1: When running in dev mode (pnpm run dev), sync.js is never called, leaving the database empty. All API calls fail with SQLITE_ERROR: no such table.
Root cause: sync.js is only called in main.js (Electron entry), not in bin/www (Node dev entry).
Fix: Call sync() in bin/www before server.listen() to ensure tables are created on startup.