Merged
Conversation
By default they’re run 100 times which gives false impression that there’s some sort of property being tested.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default they’re run 100 times which gives false impression that there’s some sort of property being tested.
NB tag for
0.7.1.0version is missing from the git repository.Howerever there are surprisingly no runtime savings from running tests only once - they test that particular expressions independent of function's inputs evaluate to known result which seem to get lifted by GHC to the toplevel and thus will evaluate only once when QuickCheck runs them repeatedly.
Still it seems reasonable to make QuickCheck run unit tests only once.