Open
Conversation
… up to date with code config
… UI to only render queue buttons shown. Updated queue db to use push/pop for faster queue updates. Also fixed large lag spike when queued button is moved in a large queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added some additional urls and noticed some performance issues with the program when the queue gets large (e.g. >10000), on startup and while running/modifying.
I went ahead and fixed some of the UI performance issues, opting to only render the queue buttons that are visible, and to dynamically render them on-the-fly. No more rendering all queued UI all at once, ever.
Now the program loads large queues (>10000) a lot faster on startup and during use, fixing some UI queue hangups I experienced.
The
Download Queuealso now shows the number of remaining queued items.Cheers,
Josh