Separate admin activity streams from regular user streams#13449
Draft
manuthecoder wants to merge 2 commits intomainfrom
Draft
Separate admin activity streams from regular user streams#13449manuthecoder wants to merge 2 commits intomainfrom
manuthecoder wants to merge 2 commits intomainfrom
Conversation
Admin users with the "show admin activities" toggle OFF were still receiving all streamed activities because broadcasts always wrote to the [user, "activities"] channel for every admin user. Fix: broadcast admin-wide activities to a separate [user, "admin_activities"] channel, and only subscribe to that channel when the admin_activities cookie is set to "everyone". This matches the existing page-load filter in MyController#activities. Fixes #13408 https://claude.ai/code/session_01R5J8wkuGRoJUg4VVnkcd2h
Use mutually exclusive channel subscriptions: admins with toggle ON subscribe only to "admin_activities" (which receives all activity broadcasts, a superset of "activities"), and admins with toggle OFF subscribe only to "activities". This avoids duplicate streamed entries for admins who are also event members. https://claude.ai/code/session_01R5J8wkuGRoJUg4VVnkcd2h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Admin users were receiving activity updates through the same stream as regular users. This change separates admin activity streams to allow for independent filtering and management of admin-specific activities.
Describe your changes
closes #13408
admin_activitiesstream instead of the regularactivitiesstreamadmin_activitiesstream rather than the sharedactivitiesstreamThe changes enable a cleaner separation of concerns where admin activity monitoring can be toggled independently without polluting the standard activity stream.
https://claude.ai/code/session_01R5J8wkuGRoJUg4VVnkcd2h