fix: qp was failing to render if flatten/condition are rendered as hi…#7998
Merged
mskorokhodov merged 1 commit intomainfrom Apr 22, 2026
Merged
fix: qp was failing to render if flatten/condition are rendered as hi…#7998mskorokhodov merged 1 commit intomainfrom
mskorokhodov merged 1 commit intomainfrom
Conversation
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/laboratory |
0.1.6-alpha-20260421104420-4d36f066cf046043def1685ceca3b48a9f39bf4d |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/render-laboratory |
0.1.6-alpha-20260421104420-4d36f066cf046043def1685ceca3b48a9f39bf4d |
npm ↗︎ unpkg ↗︎ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a null check for the query plan in the laboratory UI and updates the query plan visitor logic for 'Flatten' and 'Condition' nodes. The current implementation of the visitor logic contains several issues: overwriting the 'result' variable leads to nodes being pushed multiple times to the output array and breaks the parent-child hierarchy for conditional branches, potentially orphaning nodes in sequences.
mskorokhodov
force-pushed
the
fix/qr-high-order-flatten-node
branch
from
03f1cff to
853019e
Compare
…gh order component and not child of parallel
mskorokhodov
force-pushed
the
fix/qr-high-order-flatten-node
branch
from
853019e to
4d36f06
Compare
n1ru4l
approved these changes
Apr 21, 2026
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…gh order component and not child of parallel
Background
While testing gateway qp, found out that it was failing to render visual mode if flatten/config are rendered as hight order node.
Description
Applied fix to properly handle this scenario
Checklist