Fix unfail retry when deployment head behind error block#6529
Open
dimitrovmaksim wants to merge 1 commit intomasterfrom
Open
Fix unfail retry when deployment head behind error block#6529dimitrovmaksim wants to merge 1 commit intomasterfrom
dimitrovmaksim wants to merge 1 commit intomasterfrom
Conversation
…r block When a subgraph encounters a non-deterministic error and restarts from a checkpoint before the error block, the unfail mechanism would incorrectly stop retrying after the first attempt returned Noop. This happened because `should_try_unfail_non_deterministic` was unconditionally set to `false` after the first unfail attempt, even when the deployment head hadn't reached the error block yet. Fix: Add `UnfailOutcome::BehindErrorBlock` variant to distinguish "deployment head behind error block" (keep retrying) from other Noop cases (stop retrying). Fixes #6205
dimitrovmaksim
force-pushed
the
fix/unfail-retry-behind-error-block
branch
from
69539a8 to
5046da3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6205
When a subgraph encounters a non-deterministic error and restarts from a checkpoint before the error block, the unfail mechanism would incorrectly stop retrying after the first attempt returned Noop.
This happened because
should_try_unfail_non_deterministicwas unconditionally set tofalseafter the first unfail attempt, even when the deployment head hadn't reached the error block yet.Fix: Add
UnfailOutcome::BehindErrorBlockvariant to distinguish "deployment head behind error block" (keep retrying) from other Noop cases (stop retrying).