fix: make ingress compatible with microservices#4847
Open
ba-work wants to merge 2 commits intografana:mainfrom
Open
fix: make ingress compatible with microservices#4847ba-work wants to merge 2 commits intografana:mainfrom
ba-work wants to merge 2 commits intografana:mainfrom
Conversation
|
|
simonswine
approved these changes
Apr 13, 2026
Contributor
simonswine
left a comment
There was a problem hiding this comment.
Thanks for fixing this, sorry that it took us a while to get to it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ingress did not work with
architecture.microservices.enabled=true. Verify with the difference between following:Note
Medium Risk
Ingress service selection logic changes based on rendered component list, which can affect traffic routing in microservices deployments; impact is limited to Helm templating and chart packaging.
Overview
Fixes the
Ingresstemplate forarchitecture.microservices.enabled=trueby deriving the deployed component set viainclude "pyroscope.components"and using that to decide whether to route to per-component services (e.g.,*-query-frontend,*-distributor) vs the single-binary service.Bumps the Helm chart version from
1.20.3to1.20.4.Reviewed by Cursor Bugbot for commit e45e610. Bugbot is set up for automated code reviews on this repo. Configure here.