Skip to content

fix: make ingress compatible with microservices#4847

Open
ba-work wants to merge 2 commits intografana:mainfrom
ba-work:main
Open

fix: make ingress compatible with microservices#4847
ba-work wants to merge 2 commits intografana:mainfrom
ba-work:main

Conversation

@ba-work
Copy link
Copy Markdown

@ba-work ba-work commented Feb 18, 2026

The ingress did not work with architecture.microservices.enabled=true. Verify with the difference between following:

# fix
helm template -g . -s templates/ingress.yaml \
    --set architecture.microservices.enabled=true \
    --set ingress.enabled=true \
    --set 'ingress.hosts[0]=a'
# original
helm template -g grafana/pyroscope -s templates/ingress.yaml \
    --set architecture.microservices.enabled=true \
    --set ingress.enabled=true \
    --set 'ingress.hosts[0]=a'

Note

Medium Risk
Ingress service selection logic changes based on rendered component list, which can affect traffic routing in microservices deployments; impact is limited to Helm templating and chart packaging.

Overview
Fixes the Ingress template for architecture.microservices.enabled=true by deriving the deployed component set via include "pyroscope.components" and using that to decide whether to route to per-component services (e.g., *-query-frontend, *-distributor) vs the single-binary service.

Bumps the Helm chart version from 1.20.3 to 1.20.4.

Reviewed by Cursor Bugbot for commit e45e610. Bugbot is set up for automated code reviews on this repo. Configure here.

@ba-work ba-work requested a review from a team as a code owner February 18, 2026 18:43
@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Apr 3, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ simonswine
❌ ba-work
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, sorry that it took us a while to get to it!

@simonswine simonswine enabled auto-merge (squash) April 13, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants