Construct a crate to produce the staticlib in the subcommand.#857
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Construct a crate to produce the staticlib in the subcommand.#857copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_901485778
branch
from
78f46ae to
96581bc
Compare
This solves the issue of how does generated Rust code for bindings depend on `bridge.rs`. We create a Cargo.toml package for the generated rust code and use that to produce a staticlib. The Cargo.toml can then depend on `bridge.rs`. We're okay with this dependency being implicit like this because we want the subcommand to control which version of bridge.rs is used (and we only want to change versions when subcommand versions are changed). PiperOrigin-RevId: 901485778
copybara-service
bot
force-pushed
the
test_901485778
branch
from
96581bc to
2d217d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Construct a crate to produce the staticlib in the subcommand.
This solves the issue of how does generated Rust code for bindings
depend on
bridge.rs. We create a Cargo.toml package for the generatedrust code and use that to produce a staticlib. The Cargo.toml can then
depend on
bridge.rs. We're okay with this dependency being implicitlike this because we want the subcommand to control which version of
bridge.rs is used (and we only want to change versions when subcommand
versions are changed).