Fix protobuf bridging for nested messages.#856
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_901453677
branch
2 times, most recently
from
efca112 to
ec4a5bb
Compare
Crubit previously incorrectly assumed that the C++ generated class name for a protobuf (e.g. `MyMessage_Request`) perfectly matched the expected Rust type path (`my_message::Request`). This caused the `rs_bindings_from_cc` generator to fail to find the correct type from the Rust protobuf crate. This fix traverses the `DeclContext` in C++ to correctly reconstruct the nested `snake_case` Rust module paths, and uses this reconstructed `rust_name` in the generator instead of ignoring it. PiperOrigin-RevId: 903251309
copybara-service
Bot
force-pushed
the
test_901453677
branch
from
ec4a5bb to
ee9d342
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix protobuf bridging for nested messages.
Crubit previously incorrectly assumed that the C++ generated class name for a protobuf (e.g.
MyMessage_Request) perfectly matched the expected Rust type path (my_message::Request). This caused thers_bindings_from_ccgenerator to fail to find the correct type from the Rust protobuf crate.This fix traverses the
DeclContextin C++ to correctly reconstruct the nestedsnake_caseRust module paths, and uses this reconstructedrust_namein the generator instead of ignoring it.