Merged
Conversation
ankddev
approved these changes
Apr 19, 2026
lpil
approved these changes
Apr 20, 2026
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
I'm on to you. You're just trying to increase your LoC
Member
|
Now the that repo has over 10,000 commits, Github doesn't show line counts anymore. It's all about commit count now! |
Member
|
rats, my high score 😔 |
Member
Author
|
What I'm hearing is I should have done a single commit per updated file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running tests with insta locally this warning started popping up: "Snapshot test passes but the existing value is in a legacy format. Please run
cargo insta test --force-update-snapshotsto update to a newer format."I did as instructed!