test: add integration test for TypeScript declarations#5521
Open
nkxxll wants to merge 1 commit intogleam-lang:mainfrom
Open
test: add integration test for TypeScript declarations#5521nkxxll wants to merge 1 commit intogleam-lang:mainfrom
nkxxll wants to merge 1 commit intogleam-lang:mainfrom
Conversation
ankddev
reviewed
Mar 28, 2026
Contributor
ankddev
left a comment
ankddev
left a comment
There was a problem hiding this comment.
Thank you for picking this up! Looks nice! I've left some notes inline
nkxxll
force-pushed
the
ts_decl_test
branch
3 times, most recently
from
aa58b63 to
bbab2b6
Compare
Contributor
Author
|
fixed the comments @ankddev ;) thanks for the feedback |
ankddev
reviewed
Apr 14, 2026
Contributor
Author
|
cleaned those up thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added typescript declaration smoke test for ci.
All credit to @ankddev because he actually made the change the only problem was that npx was not present in
ci.yamlas far as I can tell. Now the test usesbunxbecausebunis installed for the tests and some stricter flags.I hope this fits the use case better now. If not I am happy to iterate on that I think this smoke test would be nice to have.
#2003