Skip to content

feat: convert remaining cli-proxy workflows to byok-copilot#2058

Merged
lpcox merged 10 commits intomainfrom
copilot/convert-cli-proxy-to-byok
Apr 17, 2026
Merged

feat: convert remaining cli-proxy workflows to byok-copilot#2058
lpcox merged 10 commits intomainfrom
copilot/convert-cli-proxy-to-byok

Conversation

@lpcox
Copy link
Copy Markdown
Collaborator

@lpcox lpcox commented Apr 17, 2026

Converts the remaining 3 Copilot cli-proxy workflows to byok-copilot:

  • firewall-issue-dispatcher.md
  • smoke-copilot.md
  • smoke-services.md

All lock files recompiled and post-processed.

Convert firewall-issue-dispatcher, smoke-copilot, and smoke-services
from features.cli-proxy to features.byok-copilot.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lpcox lpcox requested a review from Mossaka as a code owner April 17, 2026 15:07
Copilot AI review requested due to automatic review settings April 17, 2026 15:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 84.33% 84.41% 📈 +0.08%
Statements 83.56% 83.64% 📈 +0.08%
Functions 87.39% 87.39% ➡️ +0.00%
Branches 74.78% 74.82% 📈 +0.04%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/docker-manager.ts 86.8% → 87.1% (+0.30%) 86.4% → 86.7% (+0.29%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Converts the remaining Copilot cli-proxy agentic workflows to run in byok-copilot mode, aligning these workflows with the repository’s offline/BYOK Copilot execution path.

Changes:

  • Switch workflow frontmatter feature flag from cli-proxy: true to byok-copilot: true in the remaining 3 workflows.
  • Recompile/postprocess corresponding lock workflows, updating Copilot CLI install to latest and ensuring BYOK-related env is present (e.g., COPILOT_API_KEY, non-empty COPILOT_MODEL fallback).
Show a summary per file
File Description
.github/workflows/smoke-services.md Flip feature flag to byok-copilot.
.github/workflows/smoke-services.lock.yml Recompiled lock reflecting BYOK Copilot execution (incl. env + Copilot CLI install change).
.github/workflows/smoke-copilot.md Flip feature flag to byok-copilot.
.github/workflows/smoke-copilot.lock.yml Recompiled lock reflecting BYOK Copilot execution (incl. env + Copilot CLI install change).
.github/workflows/firewall-issue-dispatcher.md Flip feature flag to byok-copilot.
.github/workflows/firewall-issue-dispatcher.lock.yml Recompiled lock reflecting BYOK Copilot execution (incl. env + Copilot CLI install change).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 6/6 changed files
  • Comments generated: 3

Comment thread .github/workflows/smoke-copilot.lock.yml
Comment thread .github/workflows/smoke-services.lock.yml
Comment thread .github/workflows/firewall-issue-dispatcher.lock.yml
- Copilot engine workflows: byok-copilot: true
- Non-copilot engine workflows (claude, codex, opencode): cli-proxy: true

All 29 workflows now have explicit feature flags for proxy support.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

  • feat: switch smoke-copilot-byok from cli-proxy to byok-copilot feature
  • chore: upgrade all workflows to gh-aw v0.68.7
  • GitHub MCP (last 2 merged PRs): ✅
  • safeinputs-gh PR query: ❌
  • Playwright title contains GitHub: ✅
  • Tavily search results: ❌
  • File write + cat: ✅
  • Build (npm ci && npm run build): ✅
  • Discussion comment: ✅
  • Overall status: FAIL

Warning

⚠️ Firewall blocked 3 domains

The following domains were blocked by the firewall during workflow execution:

  • ab.chatgpt.com
  • chatgpt.com
  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"
    - "chatgpt.com"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions

This comment has been minimized.

The agent was timing out at 5 minutes with Redis + PostgreSQL services.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

lpcox and others added 2 commits April 17, 2026 10:00
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Update ghcr.io/github/gh-aw-mcpg from v0.2.22 to v0.2.23 across all 29
workflow lock files. This picks up the DIFC proxy fix for /api/graphql
404 errors on github.com repos.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results ✅ PASS

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results

Test Status
GitHub MCP (list_pull_requests) ✅ Latest merged PR: #2056 "feat: switch smoke-copilot-byok from cli-proxy to byok-copilot feature"
GitHub.com connectivity (HTTP) ✅ HTTP 200
File write/read ⚠️ Pre-step template vars not expanded — unable to verify

Overall: PARTIAL — two tests passed; file test skipped due to unexpanded template variables.

Author: @lpcox | No assignees.

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP (list merged PRs) ✅ PR #2056 returned
GitHub.com connectivity (HTTP 200)
File write/read ✅ (pre-step verified)
BYOK inference (this response)

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com

Overall: PASS@lpcox (no assignees)

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

ALL CLONES FAILED — Unable to clone any test repositories.

All gh repo clone commands failed with an SSL certificate error when connecting through the proxy:

fatal: unable to access '(localhost/redacted)
SSL certificate OpenSSL verify result: unable to get local issuer certificate (20)
Ecosystem Project Build/Install Tests Status
Bun elysia N/A ❌ CLONE_FAILED
Bun hono N/A ❌ CLONE_FAILED
C++ fmt N/A ❌ CLONE_FAILED
C++ json N/A ❌ CLONE_FAILED
Deno oak N/A ❌ CLONE_FAILED
Deno std N/A ❌ CLONE_FAILED
.NET hello-world N/A ❌ CLONE_FAILED
.NET json-parse N/A ❌ CLONE_FAILED
Go color N/A ❌ CLONE_FAILED
Go env N/A ❌ CLONE_FAILED
Go uuid N/A ❌ CLONE_FAILED
Java gson N/A ❌ CLONE_FAILED
Java caffeine N/A ❌ CLONE_FAILED
Node.js clsx N/A ❌ CLONE_FAILED
Node.js execa N/A ❌ CLONE_FAILED
Node.js p-limit N/A ❌ CLONE_FAILED
Rust fd N/A ❌ CLONE_FAILED
Rust zoxide N/A ❌ CLONE_FAILED

Overall: 0/8 ecosystems passed — ❌ FAIL

Root Cause: The proxy at localhost:18443 presents a certificate that cannot be verified against the local issuer chain. The git client rejects the SSL handshake for all HTTPS clones.

Fix: Trust the proxy CA certificate in the git/system trust store before running clone operations.

Generated by Build Test Suite for issue #2058 · ● 128K ·

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: GitHub Actions Services Connectivity ✅

All checks passed:

Check Result
Redis PING (host.docker.internal:6379) PONG
PostgreSQL ready (host.docker.internal:5432) accepting connections
SELECT 1 on smoketest DB as postgres ✅ returned 1

Note: redis-cli was not installed; Redis connectivity was verified via a raw TCP socket (RESP protocol).

🔌 Service connectivity validated by Smoke Services

@github-actions
Copy link
Copy Markdown
Contributor

Chroot Runtime Version Comparison

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3 ❌ NO
Node.js v24.14.1 v20.20.2 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

Result: Not all tests passed. Python and Node.js versions differ between host and chroot environments. The smoke-chroot label was not applied.

Tested by Smoke Chroot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants