Skip to content

Fix scala#962

Closed
felipepessoto wants to merge 2 commits intogithub:stagedfrom
felipepessoto:fix_scala
Closed

Fix scala#962
felipepessoto wants to merge 2 commits intogithub:stagedfrom
felipepessoto:fix_scala

Conversation

@felipepessoto
Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • My contribution adds a new instruction, prompt, agent, skill, or workflow file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, or workflow with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.

Description

Fix the glob pattern for Scala files


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • Update to existing instruction, prompt, agent, plugin, skill, or workflow.
  • Other (please specify):

Additional Notes

  • **.scala — Matches any file ending in .scala at any depth. However, this is technically ambiguous; some tools treat ** as matching path separators only when followed by /.
  • **/*.scala — The standard, unambiguous form. **/ matches any directory path (including none), and *.scala matches any .scala file in that directory.

By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

@felipepessoto felipepessoto requested a review from dvelton as a code owner March 10, 2026 21:50
Copilot AI review requested due to automatic review settings March 10, 2026 21:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository configuration around skill/agent discovery and includes a targeted fix to the Scala instruction applyTo glob pattern.

Changes:

  • Fix Scala instruction glob from **.scala to the unambiguous **/*.scala.
  • Normalize many plugin.json entries (remove trailing slashes; in several places switch to directory-based ./agents / ./skills/* references).
  • Add a large set of new plugin skills/agents and reference docs across multiple plugin folders.

Reviewed changes

Copilot reviewed 124 out of 271 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
plugins/napkin/skills/napkin/SKILL.md Adds a new “napkin” skill definition and usage guidance.
plugins/napkin/.github/plugin/plugin.json Updates napkin skill path formatting (trailing slash removal).
plugins/mcp-m365-copilot/agents/mcp-m365-agent-expert.md Adds a new MCP/M365 expert agent definition.
plugins/mcp-m365-copilot/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/kotlin-mcp-development/agents/kotlin-mcp-expert.md Adds a Kotlin MCP expert agent definition.
plugins/kotlin-mcp-development/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/java-mcp-development/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/java-development/skills/java-springboot/SKILL.md Adds Java Spring Boot best-practices skill.
plugins/java-development/skills/java-junit/SKILL.md Adds JUnit best-practices skill.
plugins/java-development/skills/java-docs/SKILL.md Adds Javadoc best-practices skill.
plugins/java-development/skills/create-spring-boot-java-project/SKILL.md Adds a step-by-step Spring Boot project scaffold skill.
plugins/java-development/.github/plugin/plugin.json Updates skill path formatting (trailing slash removal).
plugins/go-mcp-development/agents/go-mcp-expert.md Adds a Go MCP expert agent definition.
plugins/go-mcp-development/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/gem-team/agents/gem-reviewer.md Adds a security review agent definition.
plugins/gem-team/agents/gem-orchestrator.md Adds a multi-agent orchestration agent definition.
plugins/gem-team/agents/gem-implementer.md Adds an implementation (TDD) agent definition.
plugins/gem-team/agents/gem-documentation-writer.md Adds a documentation writer agent definition.
plugins/gem-team/agents/gem-devops.md Adds a DevOps agent definition.
plugins/gem-team/agents/gem-browser-tester.md Adds a browser/E2E tester agent definition.
plugins/gem-team/.github/plugin/plugin.json Switches gem-team plugin agent reference to directory.
plugins/frontend-web-dev/skills/playwright-generate-test/SKILL.md Adds Playwright test generation skill instructions.
plugins/frontend-web-dev/skills/playwright-explore-website/SKILL.md Adds Playwright exploration skill instructions.
plugins/frontend-web-dev/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/flowstudio-power-automate/skills/flowstudio-power-automate-mcp/references/connection-references.md Adds reference docs for FlowStudio MCP connection references.
plugins/flowstudio-power-automate/skills/flowstudio-power-automate-mcp/references/action-types.md Adds reference docs for FlowStudio MCP action types.
plugins/flowstudio-power-automate/skills/flowstudio-power-automate-mcp/references/MCP-BOOTSTRAP.md Adds bootstrap reference for calling FlowStudio MCP.
plugins/flowstudio-power-automate/skills/flowstudio-power-automate-debug/references/debug-workflow.md Adds a FlowStudio debug workflow reference.
plugins/flowstudio-power-automate/skills/flowstudio-power-automate-debug/references/common-errors.md Adds a FlowStudio common errors reference.
plugins/flowstudio-power-automate/skills/flowstudio-power-automate-build/references/trigger-types.md Adds reference templates for Power Automate triggers.
plugins/flowstudio-power-automate/skills/flowstudio-power-automate-build/references/flow-schema.md Adds flow schema reference for update_live_flow.
plugins/flowstudio-power-automate/skills/flowstudio-power-automate-build/references/build-patterns.md Adds build pattern templates for common flows.
plugins/flowstudio-power-automate/.github/plugin/plugin.json Updates skill path formatting (trailing slash removal).
plugins/edge-ai-tasks/.github/plugin/plugin.json Switches plugin agent references to directory.
plugins/devops-oncall/skills/multi-stage-dockerfile/SKILL.md Adds a multi-stage Dockerfile best-practices skill.
plugins/devops-oncall/agents/azure-principal-architect.md Adds an Azure Principal Architect agent definition.
plugins/devops-oncall/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/dataverse/skills/mcp-configure/SKILL.md Adds Dataverse MCP configuration skill instructions.
plugins/dataverse/.github/plugin/plugin.json Updates skill path formatting (trailing slash removal).
plugins/dataverse-sdk-for-python/skills/dataverse-python-usecase-builder/SKILL.md Adds a Dataverse Python SDK use case builder skill.
plugins/dataverse-sdk-for-python/skills/dataverse-python-quickstart/SKILL.md Adds a Dataverse Python SDK quickstart skill.
plugins/dataverse-sdk-for-python/skills/dataverse-python-production-code/SKILL.md Adds Dataverse Python production-code guidance skill.
plugins/dataverse-sdk-for-python/skills/dataverse-python-advanced-patterns/SKILL.md Adds Dataverse Python advanced patterns skill.
plugins/dataverse-sdk-for-python/.github/plugin/plugin.json Updates skill path formatting (trailing slash removal).
plugins/database-data-management/skills/postgresql-code-review/SKILL.md Adds a PostgreSQL code review skill.
plugins/database-data-management/agents/postgresql-dba.md Adds a PostgreSQL DBA agent definition.
plugins/database-data-management/agents/ms-sql-dba.md Adds an MS SQL DBA agent definition.
plugins/database-data-management/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/csharp-mcp-development/skills/csharp-mcp-server-generator/SKILL.md Adds a C# MCP server generator skill.
plugins/csharp-mcp-development/agents/csharp-mcp-expert.md Adds a C# MCP expert agent definition.
plugins/csharp-mcp-development/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/csharp-dotnet-development/skills/dotnet-upgrade/SKILL.md Adds a .NET upgrade analysis/execution skill.
plugins/csharp-dotnet-development/skills/dotnet-best-practices/SKILL.md Adds .NET/C# best practices skill guidance.
plugins/csharp-dotnet-development/skills/csharp-xunit/SKILL.md Adds xUnit testing best practices skill.
plugins/csharp-dotnet-development/skills/csharp-tunit/SKILL.md Adds TUnit testing best practices skill.
plugins/csharp-dotnet-development/skills/csharp-nunit/SKILL.md Adds NUnit testing best practices skill.
plugins/csharp-dotnet-development/skills/csharp-async/SKILL.md Adds C# async best practices skill.
plugins/csharp-dotnet-development/skills/aspnet-minimal-api-openapi/SKILL.md Adds ASP.NET Minimal API + OpenAPI best practices skill.
plugins/csharp-dotnet-development/agents/expert-dotnet-software-engineer.md Adds an expert .NET software engineer agent definition.
plugins/csharp-dotnet-development/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/copilot-sdk/.github/plugin/plugin.json Updates skill path formatting (trailing slash removal).
plugins/context-engineering/skills/what-context-needed/SKILL.md Adds a context-requesting skill.
plugins/context-engineering/skills/refactor-plan/SKILL.md Adds a refactor planning skill.
plugins/context-engineering/skills/context-map/SKILL.md Adds a context mapping skill.
plugins/context-engineering/agents/context-architect.md Adds a context architect agent definition.
plugins/context-engineering/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/clojure-interactive-programming/skills/remember-interactive-programming/SKILL.md Adds an interactive programming reminder skill.
plugins/clojure-interactive-programming/agents/clojure-interactive-programming.md Adds a Clojure interactive programming agent definition.
plugins/clojure-interactive-programming/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/cast-imaging/agents/cast-imaging-structural-quality-advisor.md Adds a CAST Imaging quality advisor agent definition.
plugins/cast-imaging/agents/cast-imaging-software-discovery.md Adds a CAST Imaging software discovery agent definition.
plugins/cast-imaging/agents/cast-imaging-impact-analysis.md Adds a CAST Imaging impact analysis agent definition.
plugins/cast-imaging/.github/plugin/plugin.json Switches CAST plugin agent references to directory.
plugins/azure-cloud-development/skills/azure-pricing/references/SERVICE-NAMES.md Adds Azure pricing API service name reference.
plugins/azure-cloud-development/skills/azure-pricing/references/REGIONS.md Adds Azure pricing API region mapping reference.
plugins/azure-cloud-development/skills/azure-pricing/references/COST-ESTIMATOR.md Adds cost estimation formulas reference.
plugins/azure-cloud-development/skills/azure-pricing/references/COPILOT-STUDIO-RATES.md Adds Copilot Studio rates/estimation reference.
plugins/azure-cloud-development/agents/terraform-azure-planning.md Adds Terraform planning agent definition.
plugins/azure-cloud-development/agents/terraform-azure-implement.md Adds Terraform implementation agent definition.
plugins/azure-cloud-development/agents/azure-verified-modules-terraform.md Adds AVM Terraform agent definition.
plugins/azure-cloud-development/agents/azure-verified-modules-bicep.md Adds AVM Bicep agent definition.
plugins/azure-cloud-development/agents/azure-saas-architect.md Adds Azure SaaS architect agent definition.
plugins/azure-cloud-development/agents/azure-principal-architect.md Adds Azure Principal Architect agent definition.
plugins/azure-cloud-development/agents/azure-logic-apps-expert.md Adds Azure Logic Apps expert agent definition.
plugins/azure-cloud-development/.github/plugin/plugin.json Switches Azure cloud plugin agent references to directory; normalizes skill paths.
plugins/awesome-copilot/skills/suggest-awesome-github-copilot-skills/SKILL.md Adds a skill for suggesting skills from awesome-copilot.
plugins/awesome-copilot/skills/suggest-awesome-github-copilot-instructions/SKILL.md Adds a skill for suggesting instruction files from awesome-copilot.
plugins/awesome-copilot/skills/suggest-awesome-github-copilot-agents/SKILL.md Adds a skill for suggesting agents from awesome-copilot.
plugins/awesome-copilot/agents/meta-agentic-project-scaffold.md Adds a meta scaffolding agent definition.
plugins/awesome-copilot/.github/plugin/plugin.json Adjusts agent/skill references (directory + trailing slash removal).
plugins/automate-this/.github/plugin/plugin.json Updates skill path formatting (trailing slash removal).
instructions/scala2.instructions.md Fixes Scala file glob pattern to **/*.scala.

- Get unique waves: sort ascending
- For each wave (1→n):
- If wave > 1: Present contracts from plan.yaml to agents for verification
- Getpending AND dependencies=completed AND wave= tasks where status=current
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the workflow step: Getpending should be Get pending (and the sentence could be clarified to avoid ambiguity).

Suggested change
- Getpending AND dependencies=completed AND wave= tasks where status=current
- Get pending tasks where status=current AND dependencies=completed AND wave=current

Copilot uses AI. Check for mistakes.
Comment on lines +42 to +47
"status": "completed|failed|in_progress|needs_revision",
"task_id": "[task_id]",
"plan_id": "[plan_id]",
"summary": "[brief summary ≤3 sentences]",
"failure_type": "transient|fixable|needs_replan|escalate", // Required when status=failed
"extra": {
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON example in <output_format_guide> is not valid JSON due to inconsistent indentation and the inline comment; this can confuse consumers who copy/paste. Consider either (1) making it valid JSON (remove comments, keep consistent indentation) or (2) clearly labeling it as pseudo-JSON and formatting consistently.

Copilot uses AI. Check for mistakes.
- Docker
- Docker Compose

- If you need to custom the project name, please change the `artifactId` and the `packageName` in [download-spring-boot-project-template](./create-spring-boot-java-project.prompt.md#download-spring-boot-project-template)
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar issue: custom should be customize in this sentence.

Suggested change
- If you need to custom the project name, please change the `artifactId` and the `packageName` in [download-spring-boot-project-template](./create-spring-boot-java-project.prompt.md#download-spring-boot-project-template)
- If you need to customize the project name, please change the `artifactId` and the `packageName` in [download-spring-boot-project-template](./create-spring-boot-java-project.prompt.md#download-spring-boot-project-template)

Copilot uses AI. Check for mistakes.
Comment on lines 20 to 28
"agents": [
"./agents/azure-principal-architect.md",
"./agents/azure-saas-architect.md",
"./agents/azure-logic-apps-expert.md",
"./agents/azure-verified-modules-bicep.md",
"./agents/azure-verified-modules-terraform.md",
"./agents/terraform-azure-planning.md",
"./agents/terraform-azure-implement.md"
"./agents"
],
"skills": [
"./skills/azure-resource-health-diagnose/",
"./skills/az-cost-optimize/",
"./skills/import-infrastructure-as-code/",
"./skills/azure-pricing/"
"./skills/azure-resource-health-diagnose",
"./skills/az-cost-optimize",
"./skills/import-infrastructure-as-code",
"./skills/azure-pricing"
]
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR’s title/description focuses on the Scala glob fix, but this change (and many others) modifies plugin registration patterns and adds substantial new content across multiple plugins. To keep review and rollback manageable, consider splitting into: (1) a small PR with only instructions/scala2.instructions.md, and (2) separate PR(s) for the plugin.json normalization and new plugin/skill/agent additions.

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +4
---
name: java-springboot
description: 'Get best practices for developing applications with Spring Boot.'
---
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds many new skills/agents across plugins. If the repo maintains discoverability indexes (e.g., docs/README.*.md lists), those should be updated to include the new additions so they show up in documentation/navigation.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants