-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(ci): Do not build AWS lambda layer in build step #20357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from 9 commits
7203205
b57849c
b26d4fb
df7849c
3500c6b
d8898a4
7ffc0b8
7ca058d
943eb4b
fc5fbff
cab77a9
f1e1d97
19230d7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,6 +48,10 @@ env: | |
| ${{ github.workspace }}/packages/ember/*.d.ts | ||
| ${{ github.workspace }}/packages/gatsby/*.d.ts | ||
|
|
||
| # Avoid '*' here: upload-artifact flattens paths after the first wildcard (drops the packages/ prefix). | ||
| CACHED_BUILD_LAYER_PATHS: | | ||
| ${{ github.workspace }}/packages/aws-serverless/build/aws | ||
|
|
||
| BUILD_CACHE_TARBALL_KEY: tarball-${{ github.event.inputs.commit || github.sha }} | ||
|
|
||
| # GH will use the first restore-key it finds that matches | ||
|
|
@@ -164,6 +168,40 @@ jobs: | |
| changed_browser_integration: | ||
| ${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected, | ||
| '@sentry-internal/browser-integration-tests') }} | ||
| changed_aws_serverless: | ||
| ${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected, | ||
| '@sentry/aws-serverless') }} | ||
|
|
||
| job_build_layer: | ||
| name: Build Lambda layer | ||
| needs: [job_get_metadata, job_build] | ||
| if: needs.job_build.outputs.changed_aws_serverless == 'true' || github.event_name != 'pull_request' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. E2E test fails when layer artifact is missingMedium Severity The Additional Locations (1)Reviewed by Cursor Bugbot for commit f1e1d97. Configure here. |
||
| timeout-minutes: 10 | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ env.HEAD_COMMIT }} | ||
| - name: Set up Node | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version-file: 'package.json' | ||
| - name: Restore caches | ||
| uses: ./.github/actions/restore-cache | ||
| with: | ||
| dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }} | ||
| - name: Build Lambda layer | ||
| run: yarn build:layer | ||
|
|
||
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: build-layer-output | ||
| path: ${{ env.CACHED_BUILD_LAYER_PATHS }} | ||
| retention-days: 4 | ||
| compression-level: 6 | ||
| overwrite: true | ||
|
|
||
| job_check_branches: | ||
| name: Check PR branches | ||
|
|
@@ -298,7 +336,7 @@ jobs: | |
|
|
||
| job_artifacts: | ||
| name: Upload Artifacts | ||
| needs: [job_get_metadata, job_build] | ||
| needs: [job_get_metadata, job_build, job_build_layer] | ||
| runs-on: ubuntu-24.04 | ||
| # Build artifacts are only needed for releasing workflow. | ||
| if: needs.job_get_metadata.outputs.is_release == 'true' | ||
|
|
@@ -316,6 +354,11 @@ jobs: | |
| with: | ||
| dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }} | ||
|
|
||
| - name: Restore build layer artifacts | ||
| uses: actions/download-artifact@v7 | ||
| with: | ||
| name: build-layer-output | ||
|
cursor[bot] marked this conversation as resolved.
|
||
|
|
||
|
sentry[bot] marked this conversation as resolved.
|
||
| - name: Pack tarballs | ||
| run: yarn build:tarball | ||
|
|
||
|
|
@@ -902,7 +945,7 @@ jobs: | |
| # See: https://github.com/actions/runner/issues/2205 | ||
| if: | ||
| always() && needs.job_e2e_prepare.result == 'success' && needs.job_e2e_prepare.outputs.matrix != '{"include":[]}' | ||
| needs: [job_get_metadata, job_build, job_e2e_prepare] | ||
| needs: [job_get_metadata, job_build, job_build_layer, job_e2e_prepare] | ||
|
sentry[bot] marked this conversation as resolved.
|
||
| runs-on: ubuntu-24.04 | ||
| timeout-minutes: 15 | ||
| env: | ||
|
|
@@ -948,6 +991,12 @@ jobs: | |
| with: | ||
| dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }} | ||
|
|
||
| - name: Restore build layer artifacts | ||
| uses: actions/download-artifact@v7 | ||
| if: matrix.test-application == 'aws-serverless' | ||
| with: | ||
| name: build-layer-output | ||
|
sentry[bot] marked this conversation as resolved.
sentry[bot] marked this conversation as resolved.
|
||
|
|
||
| - name: Restore tarball cache | ||
| uses: actions/cache/restore@v5 | ||
| id: restore-tarball-cache | ||
|
|
@@ -1134,6 +1183,7 @@ jobs: | |
| job_check_lockfile, | ||
| job_check_format, | ||
| job_circular_dep_check, | ||
| job_build_layer, | ||
| job_size_check, | ||
| ] | ||
| # Always run this, even if a dependent job failed | ||
|
|
||


Uh oh!
There was an error while loading. Please reload this page.