This repository was archived by the owner on Oct 15, 2025. It is now read-only.
Adding pre-commit and some formatting#1449
Open
lnxpy wants to merge 4 commits intogeorgia-tech-db:stagingfrom
Open
Adding pre-commit and some formatting#1449lnxpy wants to merge 4 commits intogeorgia-tech-db:stagingfrom
lnxpy wants to merge 4 commits intogeorgia-tech-db:stagingfrom
Conversation
Contributor
There was a problem hiding this comment.
👋 Hello @lnxpy, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify that your PR is up-to-date with
georgia-tech-db/evamasterbranch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pullandgit merge masterlocally. - ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.
Author
I think this CI message needs an update too. The default branch is |
Member
|
@lnxpy Thanks for the effort, let me fix the build and then merge your PR. |
Author
|
Hi @gaurav274! I'm working on #1348 as well so the contribution guideline will need a major update after that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
test/third_party_tests/*.db(it gets generated whenever someone runs the tests)pre-commitconfigurations (usingblackandcheck-docstring-firstfor better code quality insurance)We can specify which docstring convention should be checked while committing.
source/dev-guide/contribute.htmldoc needs to be updated. I can work on them as well.This PR closes #1347