fix(sync): honor dry_run flag in performFullSync#306
Open
davemorin wants to merge 1 commit intogarrytan:masterfrom
Open
fix(sync): honor dry_run flag in performFullSync#306davemorin wants to merge 1 commit intogarrytan:masterfrom
davemorin wants to merge 1 commit intogarrytan:masterfrom
Conversation
performFullSync was called on first-sync and force-full paths without checking opts.dryRun. The incremental sync path (line 152) correctly checked the flag, but the full sync path skipped it entirely. Fixes garrytan#140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
performFullSync(first-sync / force-full paths) did not checkopts.dryRun, sosync_brainwithdry_run: trueon a first sync still wrote pages. The incremental sync path correctly returned adry_runstatus result, but the full sync path skipped the check entirely.Adds an early return matching the incremental path pattern (line 152-170) when
opts.dryRunis true.Fixes #140
This contribution was developed with AI assistance (Claude Code).