Open
Conversation
fingolfin
added
kind: bug
fingolfin
force-pushed
the
codex/CosetLeadersMatFFE-crash
branch
from
13e67d6 to
29dd0f5
Compare
Reject matrices with dependent rows before building the internal search tables for CosetLeadersMatFFE. This avoids a crash in the 8-bit path and restores correct behaviour for square full-rank inputs. AI assistance: Codex reproduced the crash, traced it to the internal row-independence assumption, added a regression test, and prepared the fix. Co-authored-by: Codex <codex@openai.com>
fingolfin
force-pushed
the
codex/CosetLeadersMatFFE-crash
branch
from
29dd0f5 to
1653d43
Compare
fingolfin
commented
Apr 20, 2026
| tofind := q^m; | ||
| t := TransposedMat(mat); | ||
| vl := []; | ||
| vl[m+1] := false; |
Member
Author
There was a problem hiding this comment.
Should use EmptyPlist.
Also later on Add(vl[i],false); seems also fishy.
And perhaps the C layer could also have some better argument validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject matrices with dependent rows before building the internal search tables for CosetLeadersMatFFE. This avoids a crash in the 8-bit path and restores correct behaviour for square full-rank inputs.
AI assistance: Codex reproduced the crash, traced it to the internal row-independence assumption, added a regression test, and prepared the fix.
Co-authored-by: Codex codex@openai.com