Skip to content

[smallantimagmas] Update to 0.5.1#1228

Merged
fingolfin merged 1 commit intomainfrom
automatic/smallantimagmas
Sep 26, 2025
Merged

[smallantimagmas] Update to 0.5.1#1228
fingolfin merged 1 commit intomainfrom
automatic/smallantimagmas

Conversation

@gap-package-distribution-bot
Copy link
Copy Markdown
Contributor

@gap-package-distribution-bot gap-package-distribution-bot Bot commented Sep 20, 2025 •
edited
Loading

@gap-package-distribution-bot gap-package-distribution-bot Bot added automated pr Automatically applied to PRs created by a GH workflow package update labels Sep 20, 2025
@limakzi
Copy link
Copy Markdown
Member

limakzi commented Sep 20, 2025

@fingolfin, @james-d-mitchell, @olexandr-konovalov
I think, it failed because we have same naming convention for the method that filters grupoids up to isomorphism. I did that for purpose.
Since, smallsemi is magma too, we have conflict.

gap> SmallSemigroup(2,1);
<small semigroup of size 2>
gap> IsMagma(SmallSemigroup(2,1));
true

How shall we solve that?

@limakzi limakzi mentioned this pull request Sep 20, 2025
Open
@james-d-mitchell
Copy link
Copy Markdown
Collaborator

james-d-mitchell commented Sep 22, 2025

Easiest thing to do would be to declare UpToIsomorphism as an operation in SmallSemi. Would be happy to merge a PR with those changes and to make a release once it's merged @limakzi

@fingolfin
Copy link
Copy Markdown
Member

fingolfin commented Sep 22, 2025

That's indeed the usual way we address this kind of conflict. Alternatively one of the two packages can rename its function.

@limakzi
Copy link
Copy Markdown
Member

limakzi commented Sep 22, 2025

Rather, smallantimagmas should change it to Operation; correct me if I am wrong.

Note:
https://github.com/gap-packages/smallsemi/blob/c985beb47dd429d7e96b822593ce3c6ea3d0d07a/gap/enums.gd#L640

https://github.com/gap-packages/smallantimagmas/blob/6190f7a71d9fcda8e315af79a32b3bb40edd8136/lib/utils.gd#L20

@fingolfin
Copy link
Copy Markdown
Member

fingolfin commented Sep 22, 2025

Oh if it is already an operation in smallsemi then that indeed makes it simpler, you can just change it to be an operation in smallantimagmas, excellent

@gap-package-distribution-bot gap-package-distribution-bot Bot force-pushed the automatic/smallantimagmas branch 3 times, most recently from 6ede2ff to 230e3c1 Compare September 24, 2025 00:07
@fingolfin fingolfin added the skip tests No CI tests are run for PRs with this label. Otherwise they run each time the distro is updated label Sep 24, 2025
@fingolfin
Copy link
Copy Markdown
Member

fingolfin commented Sep 24, 2025

@limakzi I put CI for this PR on hold for this PR (by adding a label) for the time being, so we don't waste resources each time another package is updated (triggering a re-run of the CI here).

Once you are ready to post a new version, please ping me so I can remove the label.

@fingolfin fingolfin removed the skip tests No CI tests are run for PRs with this label. Otherwise they run each time the distro is updated label Sep 24, 2025
@gap-package-distribution-bot gap-package-distribution-bot Bot changed the title [smallantimagmas] Update to 0.5.0 [smallantimagmas] Update to 0.5.1 Sep 26, 2025
@gap-package-distribution-bot
Copy link
Copy Markdown
Contributor Author

gap-package-distribution-bot Bot commented Sep 26, 2025 •
edited
Loading

Package Evaluation Report for GAP master

Job Properties

Testing: master/2025-09-26-12:48:28-ec07f729 vs master/2025-09-26-12:38:17-ab7a8af8

Generated by Workflow: https://github.com/gap-system/PackageDistro/actions/runs/18037478577

In total, 166 packages were tested, out of which 163 succeeded, 0 failed and 3 were skipped.

✔️ Packages still succeeding

163 package(s) succeeded tests also on the previous version.

Click to show packages!

➖ Packages that were skipped

3 package(s) skipped tests also on the previous version.

Click to show packages!

@fingolfin fingolfin merged commit 00b7916 into main Sep 26, 2025
167 checks passed
@fingolfin fingolfin deleted the automatic/smallantimagmas branch September 26, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated pr Automatically applied to PRs created by a GH workflow package update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@limakzi @james-d-mitchell @fingolfin