Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I understand this is opinionated, feel free to reject this PR.
I propose that, for future development, we switch away from requirements.txt since it is an outdated standard for dependencies.
The reason I chose Devenv/Nix is because:
A) It ensures that everyone is using the correct Python version
B) All dependencies can be defined from Nixpkgs
C) Direnv auto-enables the Devenv environment when the developer enters the directory
D) Devenv doesn't just make Python reproducible, but also contains tools for declaratively installing toolchains for other languages. This means that npm, uv, and whatever else could be used in this repo going forward, don't need to be manually set up by every developer. Setup is automatic.
Of course, most of the same things can be achieved with uv or poetry as well.