Skip to content

add packit configuration#171

Merged
geemus merged 1 commit intofog:masterfrom
evgeni:packit
Feb 7, 2026
Merged

add packit configuration#171
geemus merged 1 commit intofog:masterfrom
evgeni:packit

Conversation

@evgeni
Copy link
Copy Markdown
Contributor

@evgeni evgeni commented Feb 2, 2026

Packit is a service that allows to build RPM packages (using COPR) and (optionally) run tests (using Testing Farm).

This makes it easy to verify PRs in "production like" setups, where the code comes from a package and not from git.

As fog (and fog-kubevirt) is heavily used in the Foreman ecosystem, this PR uses foreman-packaging as a base (also, fog-kubevirt is not packaged in Fedora/EPEL, like fog-core).

For this integration to work, someone with org-admin permissions in the fog organization would need to follow https://packit.dev/docs/guide#setup once, as soon as the integration is enabled for the org, individual repos can benefit from it without further setup (besides having a configuration like in this PR).

Is this something the fog community would be interested in?

@agrare
Copy link
Copy Markdown
Collaborator

agrare commented Feb 2, 2026

For this integration to work, someone with org-admin permissions in the fog organization would need to follow https://packit.dev/docs/guide#setup once, as soon as the integration is enabled for the org, individual repos can benefit from it without further setup (besides having a configuration like in this PR).

Is this something the fog community would be interested in?

/cc @geemus

Comment thread .packit.yaml Outdated
@ekohl
Copy link
Copy Markdown

ekohl commented Feb 3, 2026

Is this something the fog community would be interested in?

I'd like to add that Foreman consumes more fog libraries. In particular, I'd be interested fog-libvirt to also have this.

@geemus
Copy link
Copy Markdown
Member

geemus commented Feb 5, 2026

I'm open to it if folks think it will be useful/valuable. I also have no real experience or exposure to it. Have others used it that can share their experience, and/or anything I should be aware of before setting it up? Thanks.

@ekohl
Copy link
Copy Markdown

ekohl commented Feb 5, 2026

A concrete use case: we have theforeman/foreman#10824 that depends on fog/fog-libvirt#185. In Foreman you can see https://github.com/theforeman/foreman/pull/10824/checks?check_run_id=60830936571 which is how you see Packit. Then you can't really test that using RPMs because there is no patched RPM for fog-libvirt. The proposed config here would add a Packit build that creates an RPM for every PR.

Now this repo is fog-kubevirt and I'm sure there are also examples for https://github.com/theforeman/foreman_kubevirt & this repo, but the above example was on the top of my mind.

@evgeni
Copy link
Copy Markdown
Contributor Author

evgeni commented Feb 5, 2026

Another usage example (albeit not fog related) can be seen in https://theforeman.org/2023/11/testing-a-foreman-installer-patch-with-packit-and-forklift.html

@geemus
Copy link
Copy Markdown
Member

geemus commented Feb 7, 2026

@ekohl @evgeni - awesome, thanks for that context. Just wanted to get a bit more context before working through this. It all sounds good, so I'll see what I can do here.

Copy link
Copy Markdown
Member

@geemus geemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (broadly anyway, I didn't closely review config specifics, figure we can fix them if/when needed)

@geemus
Copy link
Copy Markdown
Member

geemus commented Feb 7, 2026

Ok, I believe I have done the org level setup for this now. Will bring this in so we can try it. Just let me know if you need anything else.

P.S. I added the integration to both this repo and fog-libvirt, so we can add comparable config over there to get that running if desired. cc @ekohl

If this looks good and we want to add it to more repos, just let me know. I don't think I'm watcher on everything any more, so feel free to ping me specifically if needed.

@geemus geemus merged commit 9db2320 into fog:master Feb 7, 2026
4 checks passed
@geemus
Copy link
Copy Markdown
Member

geemus commented Feb 7, 2026

Or not, after the fact I noticed this: packit/notifications#710 (I'll work on it, guess I need to setup a FAS account too)

@geemus
Copy link
Copy Markdown
Member

geemus commented Feb 7, 2026

Ok, jumped through those hoops too (I had overlooked it in the setup guide, TLDR I guess). Just let me know if you end up needing anything further here.

@evgeni
Copy link
Copy Markdown
Contributor Author

evgeni commented Feb 7, 2026

I've rebased #172 and it seems to build an RPM now

Thanks!

@evgeni evgeni deleted the packit branch February 7, 2026 15:05
@evgeni
Copy link
Copy Markdown
Contributor Author

evgeni commented Feb 7, 2026

and also seems to work for fog-libvirt: fog/fog-libvirt#187

@geemus
Copy link
Copy Markdown
Member

geemus commented Feb 7, 2026

Great, thanks!

@ekohl
Copy link
Copy Markdown

ekohl commented Feb 8, 2026

Thanks @geemus!

agrare added a commit that referenced this pull request Feb 18, 2026
* Runtime values for memory & CPU from VMI -> VM -> server (#173)
* Fix the mocked list_storageclasses response (#172)
* Add packit configuration (#171)
@agrare
Copy link
Copy Markdown
Collaborator

agrare commented Feb 18, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants