Conversation
/cc @geemus |
I'd like to add that Foreman consumes more fog libraries. In particular, I'd be interested fog-libvirt to also have this. |
|
I'm open to it if folks think it will be useful/valuable. I also have no real experience or exposure to it. Have others used it that can share their experience, and/or anything I should be aware of before setting it up? Thanks. |
|
A concrete use case: we have theforeman/foreman#10824 that depends on fog/fog-libvirt#185. In Foreman you can see https://github.com/theforeman/foreman/pull/10824/checks?check_run_id=60830936571 which is how you see Packit. Then you can't really test that using RPMs because there is no patched RPM for fog-libvirt. The proposed config here would add a Packit build that creates an RPM for every PR. Now this repo is fog-kubevirt and I'm sure there are also examples for https://github.com/theforeman/foreman_kubevirt & this repo, but the above example was on the top of my mind. |
|
Another usage example (albeit not fog related) can be seen in https://theforeman.org/2023/11/testing-a-foreman-installer-patch-with-packit-and-forklift.html |
geemus
left a comment
There was a problem hiding this comment.
lgtm (broadly anyway, I didn't closely review config specifics, figure we can fix them if/when needed)
|
Ok, I believe I have done the org level setup for this now. Will bring this in so we can try it. Just let me know if you need anything else. P.S. I added the integration to both this repo and fog-libvirt, so we can add comparable config over there to get that running if desired. cc @ekohl If this looks good and we want to add it to more repos, just let me know. I don't think I'm watcher on everything any more, so feel free to ping me specifically if needed. |
|
Or not, after the fact I noticed this: packit/notifications#710 (I'll work on it, guess I need to setup a FAS account too) |
|
Ok, jumped through those hoops too (I had overlooked it in the setup guide, TLDR I guess). Just let me know if you end up needing anything further here. |
|
I've rebased #172 and it seems to build an RPM now Thanks! |
|
and also seems to work for fog-libvirt: fog/fog-libvirt#187 |
|
Great, thanks! |
|
Thanks @geemus! |
Packit is a service that allows to build RPM packages (using COPR) and (optionally) run tests (using Testing Farm).
This makes it easy to verify PRs in "production like" setups, where the code comes from a package and not from git.
As fog (and fog-kubevirt) is heavily used in the Foreman ecosystem, this PR uses foreman-packaging as a base (also, fog-kubevirt is not packaged in Fedora/EPEL, like fog-core).
For this integration to work, someone with org-admin permissions in the fog organization would need to follow https://packit.dev/docs/guide#setup once, as soon as the integration is enabled for the org, individual repos can benefit from it without further setup (besides having a configuration like in this PR).
Is this something the fog community would be interested in?